Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.12.1 #893

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Release 2.12.1 #893

merged 6 commits into from
Nov 21, 2024

Conversation

chengzhuzhang
Copy link
Contributor

Description

Prepare for releasing 2.12.1 before migrating to the new code base using xarray/xcdat

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

Copy link
Collaborator

@tomvothecoder tomvothecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Initial code review

conda-env/ci.yml Outdated Show resolved Hide resolved
conda-env/dev-nompi.yml Outdated Show resolved Hide resolved
conda-env/dev.yml Outdated Show resolved Hide resolved
conda-env/dev-nompi.yml Outdated Show resolved Hide resolved
conda-env/dev.yml Outdated Show resolved Hide resolved
conda-env/dev-nompi.yml Outdated Show resolved Hide resolved
conda-env/dev.yml Outdated Show resolved Hide resolved
@tomvothecoder
Copy link
Collaborator

Use this notebook for regression testing and modify as needed (e.g., update paths, remove function that removes .nc files for comparison, etc.)

https://github.com/E3SM-Project/e3sm_diags/blob/cdat-migration-fy24/auxiliary_tools/cdat_regression_testing/843-migration-phase3/run-script-model-vs-obs/model_vs_obs_netcdf.ipynb

@chengzhuzhang
Copy link
Contributor Author

@tomvothecoder thank you for sharing the regression notebook. Unfortunately, the save_netcdf flag didn't turn on for both the baseline and new run. So I'm not able to use the notebook. Instead I ran the metrics_checker.py and image_checker.py. Both runs are consistent, the diff is expected:

1. File missing in second directory: lat_lon/OMI-MLS/OMI-MLS-TCO-ANN-60S60N.png (#879)
2. Images do not match: qbo/QBO-ERA-Interim/qbo_diags.png (#836)

pressure-latitude(stratosphere) and tropical cyclone analysis are not included in the tests, they were tested individually before merging the PR.

@chengzhuzhang chengzhuzhang marked this pull request as ready for review November 19, 2024 18:49
Copy link
Collaborator

@tomvothecoder tomvothecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Jill!

@chengzhuzhang
Copy link
Contributor Author

@tomvothecoder Thank you for the review!
As a reference, the complete run is available here:
https://portal.nersc.gov/cfs/e3sm/chengzhu/complete_run/v2.12.1/e3sm_diags_extended/viewer/

The annual cycle zonal mean set is not included, only ANN is included in the run script.

@chengzhuzhang chengzhuzhang merged commit ca41b0e into main Nov 21, 2024
4 checks passed
@chengzhuzhang chengzhuzhang deleted the release_2.12.1 branch November 21, 2024 00:10
@tomvothecoder
Copy link
Collaborator

Nice, thanks for the release @chengzhuzhang. Looks like we can merge cdat-migration-fy24 to main soon 😀

@chengzhuzhang
Copy link
Contributor Author

Nice, thanks for the release @chengzhuzhang. Looks like we can merge cdat-migration-fy24 to main soon 😀

YEAHHH!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants