-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.12.1 #893
Release 2.12.1 #893
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My Initial code review
Co-authored-by: Tom Vo <[email protected]>
Use this notebook for regression testing and modify as needed (e.g., update paths, remove function that removes |
@tomvothecoder thank you for sharing the regression notebook. Unfortunately, the save_netcdf flag didn't turn on for both the baseline and new run. So I'm not able to use the notebook. Instead I ran the metrics_checker.py and image_checker.py. Both runs are consistent, the diff is expected:
pressure-latitude(stratosphere) and tropical cyclone analysis are not included in the tests, they were tested individually before merging the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks Jill!
@tomvothecoder Thank you for the review! The annual cycle zonal mean set is not included, only |
Nice, thanks for the release @chengzhuzhang. Looks like we can merge |
YEAHHH! |
Description
Prepare for releasing 2.12.1 before migrating to the new code base using xarray/xcdat
Checklist
If applicable: