-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DevOps]: CDAT Migration: Replace setup.py
with pyproject.toml
for modern Python packaging
#895
Conversation
setup.py
with pyproject.toml
for modern Python packagingsetup.py
with pyproject.toml
for modern Python packaging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomvothecoder, most of my comments are really more to do with choices being made in e3sm_diags generally, since I don't look it over that often. Those might be better addressed in separate PRs.
The main ones that are relevant for now are potentially removing wheel
and adding matplotlib
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
…r modern Python packaging (#895)
Description
setup.py
withpyproject.toml
for modern Python packaging #890pre-commit
configdefault_stages
usingpre-commit migrate-config
Checklist
If applicable: