Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevOps]: CDAT Migration: Replace setup.py with pyproject.toml for modern Python packaging #895

Merged
merged 9 commits into from
Nov 20, 2024

Conversation

tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Nov 12, 2024

Description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@tomvothecoder tomvothecoder changed the base branch from main to cdat-migration-fy24 November 12, 2024 23:03
@tomvothecoder tomvothecoder self-assigned this Nov 12, 2024
@tomvothecoder tomvothecoder added the DevOps CI/CD, configuration, etc. label Nov 12, 2024
@tomvothecoder tomvothecoder marked this pull request as ready for review November 14, 2024 21:10
@tomvothecoder tomvothecoder changed the title CDAT Migration: Replace setup.py with pyproject.toml for modern Python packaging [DevOps]: CDAT Migration: Replace setup.py with pyproject.toml for modern Python packaging Nov 14, 2024
pyproject.toml Outdated Show resolved Hide resolved
@tomvothecoder tomvothecoder requested a review from xylar November 18, 2024 22:04
Copy link
Contributor

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomvothecoder, most of my comments are really more to do with choices being made in e3sm_diags generally, since I don't look it over that often. Those might be better addressed in separate PRs.

The main ones that are relevant for now are potentially removing wheel and adding matplotlib.

pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
Copy link
Contributor

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@tomvothecoder tomvothecoder merged commit 7b9b9be into cdat-migration-fy24 Nov 20, 2024
6 checks passed
tomvothecoder added a commit that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps CI/CD, configuration, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Replace setup.py with pyproject.toml for modern Python packaging
2 participants