Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.9 support #919

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Drop Python 3.9 support #919

merged 2 commits into from
Jan 17, 2025

Conversation

tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Jan 17, 2025

Description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@tomvothecoder tomvothecoder self-assigned this Jan 17, 2025
@tomvothecoder tomvothecoder added the DevOps CI/CD, configuration, etc. label Jan 17, 2025
@tomvothecoder tomvothecoder merged commit 287ad87 into main Jan 17, 2025
5 checks passed
@xylar
Copy link
Contributor

xylar commented Jan 17, 2025

@tomvothecoder, this will not be part of 3.0.0, correct?

@tomvothecoder
Copy link
Collaborator Author

@xylar Are we still supporting Python 3.9 in the next E3SM Unified? If we are, I'll need to revert this merge and keep it open for later.

@xylar
Copy link
Contributor

xylar commented Jan 17, 2025

Yes, we have to. We only have python 3.9 and 3.10 because of the cdat madness we still have to support. I don't feel good about dropping python 3.9 and having only python 3.10.

tomvothecoder added a commit that referenced this pull request Jan 17, 2025
@tomvothecoder
Copy link
Collaborator Author

Yes, we have to. We only have python 3.9 and 3.10 because of the cdat madness we still have to support. I don't feel good about dropping python 3.9 and having only python 3.10.

Thanks for clarifying, I should have reached out first before getting to excited to merge this PR. I just reverted the merge.

I thought we were dropping Python 3.9 support based on this message from you on 10/1/24 in the e3sm-unified-testing-releases Slack:

The latest release of pyproj has just dropped support for python 3.9:
https://github.com/pyproj4/pyproj/releases/tag/3.7.0
This likely means that E3SM-Unified 1.11.0 will only be able to support python 3.10 to accommodate both this new pyproj and CDAT

But I saw you're going to use 3.6.1 for python <3.10 and 3.7.0 for python >=3.10 here.

In any case, I'm looking forward to getting rid of Python 3.9 and CDAT too.

@xylar
Copy link
Contributor

xylar commented Jan 17, 2025

Oh, I forgot I had said that back in October but I think we do want to keep it if we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps CI/CD, configuration, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DevOps]: Drop Python 3.9 support
2 participants