Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in download file #102

Merged
merged 7 commits into from
Feb 20, 2025
Merged

Fix bug in download file #102

merged 7 commits into from
Feb 20, 2025

Conversation

dglemos
Copy link
Collaborator

@dglemos dglemos commented Feb 19, 2025 •
edited
Loading

Updates

  • fixes gene omim id, HGNC id and synonyms
  • return unique variant types
  • return unique phenotypes
  • rename inferred variant consequence to variant consequence - we already have both evidence/inferred in the db
  • remove new lines from comments

@dglemos dglemos requested a review from olaaustine February 20, 2025 10:35
olaaustine
olaaustine approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@olaaustine olaaustine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works well with the VEP plugin

@olaaustine olaaustine merged commit 6360c14 into EBI-G2P:main Feb 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olaaustine olaaustine olaaustine approved these changes

Assignees

@olaaustine olaaustine

Labels
release/v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dglemos @olaaustine