Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the permissions to add comments #113

Merged

Conversation

dglemos
Copy link
Collaborator

@dglemos dglemos commented Feb 27, 2025

The method check_panel_permission does not have the intended behaviour.
Update the method to allow users to edit the record if they have permission to edit at least one of the panels linked to the record.

check_panel_permission is being called by LGDEditComment

This bug affects the following endpoint:
lgd/<str:stable_id>/comment/

Copy link
Collaborator

@seeta-ramaraju seeta-ramaraju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seeta-ramaraju seeta-ramaraju merged commit 0ccd496 into EBI-G2P:release/v2 Feb 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants