Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVA-3732 - New script to help find children that match the definition of a new term #452

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

EVA-3732 - New script to help find children that match the definition of a new term #452

wants to merge 2 commits into from

Conversation

tcezard
Copy link
Member

@tcezard tcezard commented Jan 22, 2025

No description provided.

@tcezard tcezard requested a review from apriltuesday January 22, 2025 23:06
apriltuesday
apriltuesday approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@apriltuesday apriltuesday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, my comments are just nitpicks. Would be good to mention use of this script in the manual curation SOP, but that can be done later.

bin/trait_mapping/get_children_with_keywords.py Show resolved Hide resolved
bin/trait_mapping/get_children_with_keywords.py Outdated Show resolved Hide resolved
bin/trait_mapping/get_children_with_keywords.py Outdated Show resolved Hide resolved
bin/trait_mapping/get_children_with_keywords.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apriltuesday apriltuesday apriltuesday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcezard @apriltuesday