Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: April Shen <[email protected]>
  • Loading branch information
tcezard and apriltuesday authored Jul 1, 2024
1 parent 21d0604 commit cd18a83
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public ResponseEntity<?> getSubmissionsbyStatus(@PathVariable("status") Submissi

@Operation(summary = "Given a submission id, this endpoint updates the processing status of the submission to the one provided",
security = {@SecurityRequirement(name = "basicAuth")
})
})
@Parameters({
@Parameter(name="submissionId", description = "Id of the submission whose status needs to be updated",
required = true, in= ParameterIn.PATH),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public SubmissionProcessing(String submissionId) {
@Column(nullable = false)
private String status;

@NonNull
@NonNull
@Column(nullable = false, columnDefinition = "INTEGER DEFAULT 5")
private Integer priority = 5;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,8 @@ public List<SubmissionProcessing> getSubmissionsByProcessingStepAndStatus(Submis
}

public SubmissionProcessing markSubmissionProcessStepAndStatus(String submissionId,
SubmissionProcessingStep step,
SubmissionProcessingStatus status) {
SubmissionProcessingStep step,
SubmissionProcessingStatus status) {
SubmissionProcessing submissionProc = submissionProcessingRepository.findBySubmissionId(submissionId);
submissionProc.setStep(step.toString());
submissionProc.setStatus(status.toString());
Expand Down

0 comments on commit cd18a83

Please sign in to comment.