Recaculating coordinates breaks rendering of stereo chem #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inside the mol. Setting prepareMolsBeforeDrawing seems to fix this
|
Thanks. This fix is for the viewer only. Do you have a sense of what is wrong/needs updating on the edit mol object itself? The ideal is to let the depiction be reflecting the edit mol state as close as possible. |
|
Inside the render logic it calls wedgeMolBonds which probably fixes the problem. The worrying part is we don’t know why it broke. Upstream probably needs some sort of fix. Unfortunately I can’t make heads or tails of their code. There’s way too much spaghetti |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When recalculating coordinates some of the stereo chem is not updated inside the mol. Setting prepareMolsBeforeDrawing seems to fix this.
This fixes issues #24 and #27