Remove work-around in regression testing script #5034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EZoni
added
component: tests
RemiLehe
approved these changes
Jul 9, 2024
|
Hm, it seems that one of the CI tests is failing. |
EZoni
force-pushed
the
EZoni_regtest_workaround
branch
from
ce22f36 to
0a24569
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the comment AMReX-Codes/regression_testing#136 (comment), the issue reported in AMReX-Codes/regression_testing#136 should now be fixed thanks to AMReX-Codes/regression_testing#141.
If that's the case, it should be possible to remove the work-around that had been introduced in #4882.