Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation on how to build on top of EESSI #118

Merged
merged 7 commits into from
Nov 7, 2023

Conversation

casparvl
Copy link
Collaborator

As discussed on Slack, there is much we can do to make this easier with a module. Still, I think it's useful to have some documentation in place as soon as we can. We can then take it from there if there are improvements :)

Copy link
Collaborator

@trz42 trz42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Left a few comments.

Haven't tried it yet.

docs/using_eessi/building_on_eessi.md Outdated Show resolved Hide resolved
docs/using_eessi/building_on_eessi.md Outdated Show resolved Hide resolved
docs/using_eessi/building_on_eessi.md Outdated Show resolved Hide resolved
docs/using_eessi/building_on_eessi.md Outdated Show resolved Hide resolved
docs/using_eessi/building_on_eessi.md Outdated Show resolved Hide resolved
docs/using_eessi/building_on_eessi.md Outdated Show resolved Hide resolved
Caspar van Leeuwen added 2 commits October 30, 2023 15:14
…sure it's clear the EESSI environment needs to be loaded before loading the module that was build on top
trz42
trz42 previously requested changes Nov 3, 2023
Copy link
Collaborator

@trz42 trz42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested the procedure. It worked after doing one important swap of commands in the configuration. Added two minor suggestions.

Should be easy to change.

docs/using_eessi/building_on_eessi.md Outdated Show resolved Hide resolved
docs/using_eessi/building_on_eessi.md Outdated Show resolved Hide resolved
docs/using_eessi/building_on_eessi.md Outdated Show resolved Hide resolved
@ocaisa ocaisa dismissed trz42’s stale review November 7, 2023 08:39

Comments addressed

@ocaisa ocaisa merged commit b0be38d into EESSI:main Nov 7, 2023
1 check passed
@casparvl casparvl added the documentation Improvements or additions to documentation label Nov 7, 2023
@casparvl casparvl deleted the builing_on_eessi_with_easybuild branch August 15, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants