Handle longer dev.eessi.io prefix in ingestion
#203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested it on the tarball from EESSI/dev.eessi.io-example#7 / https://github.com/EESSI/staging/pull/2175, but now the problem shifts to the next parameter: |
|
Ah dang and I merged the staging pr... |
bedroge
reviewed
Dec 2, 2024
bedroge
reviewed
Dec 2, 2024
bedroge
reviewed
Dec 2, 2024
bedroge
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Tested this on the tarballs from EESSI/dev.eessi.io-example#7, and works like a charm. Thanks @Neves-P!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue when ingesting a tarball with an installation in a non-standard prefix coming from
dev.eessi.io. This currently fails as spotted by @bedroge when merging https://github.com/EESSI/staging/pull/2176.The call to
ingest_${tar_contents_type_dir}_tarball()should only point toingest_init_tarball(),ingest_scritps_tarball(),ingest_compat_tarball()oringest_software_tarball(). This fails, because when ingesting indev.eessi.io${tar_contents_type_dir}will instead be$EESSI_DEV_PROJECT(as currently defined here, to be changed to something not hard-coded soon.) Here I add a condition to look for the type of tarball to be ingested differently indev.eessi.iobuilds.