Various fixups #38
Merged
Various fixups #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cooperq
reviewed
Feb 16, 2024
lib/src/diag_device.rs
Outdated
| @@ -123,7 +124,7 @@ impl DiagDevice { | |||
| }) | |||
| } | |||
|
|
|||
| pub fn write_request(&mut self, req: &Request) -> DiagResult<()> { | |||
| fn write_request(&mut self, req: &Request) -> DiagResult<()> { | |||
There was a problem hiding this comment.
Why did we decide this function is no longer public?
There was a problem hiding this comment.
It's not used anywhere but internally to the module, and (for now) there's no requests an outside user would send besides the ones we're already using internally
cooperq
requested changes
Feb 16, 2024
This way, even if the program exits unexpectedly, there's a reasonable value for the "end time" of a log.
wgreenberg
force-pushed
the
various-fixups
branch
2 times, most recently
from
7ef1031
to
d156401
Compare
|
Finally tracked down the weird async race condition stuff, so imo this is now ready for review! We should do some field testing with these changes, but I'm fine if that happens either as a build from this branch, or a build from main after we merge it. |
Mixing async and sync I/O leads to a multitude of complications, and generally speaking it's much more convenient to stick to one paradigm or the other. Since axum (and many other HTTP servers) use async, and since async is a convenient model for performing operations like "handle an MPSC message or file read, whichever happens first", let's commit to an async interface.
wgreenberg
force-pushed
the
various-fixups
branch
from
d156401
to
0b6c06c
Compare
cooperq
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a couple fixups i've been thinking about:
Not ready for merging yet, but wouldn't mind a first-pass review