Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updated log.warn to log.warning #58

Merged
merged 1 commit into from
Jun 10, 2024
Merged

fix: updated log.warn to log.warning #58

merged 1 commit into from
Jun 10, 2024

Conversation

marianne013
Copy link
Contributor

Summary

Replaces log.warn with the python standard log.warning

Related issue :

fixes #53

@marianne013 marianne013 mentioned this pull request May 17, 2024
Closed
@brucellino brucellino self-assigned this May 17, 2024
@gwarf
Copy link
Member

gwarf commented May 31, 2024

An update: I aim at publishing a new BDII release at the end of next week, in case implementing additional tests have not been possible, I will just merge this PR as it is.

@marianne013
Copy link
Contributor Author

If it's any consolation we've been running this code for weeks at our site.

@gwarf
Copy link
Member

gwarf commented May 31, 2024

Definitely good to hear, thanks @marianne013.
Sorry again for the delay to handle this.

@gwarf gwarf marked this pull request as ready for review June 10, 2024 13:40
@gwarf gwarf requested a review from a team as a code owner June 10, 2024 13:40
gwarf
gwarf approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@gwarf gwarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks, will merge, we can add test later when time permits.

@gwarf gwarf merged commit e8177ba into EGI-Federation:main Jun 10, 2024
8 checks passed
@gwarf gwarf mentioned this pull request Jun 14, 2024
Merged
ellert pushed a commit that referenced this pull request Jun 15, 2024
@gwarf
Prepare 6.0.2 (#60)
f0391a2 
# [6.0.2] - 2024-06-14

# Changed

- Fix for IPv6 support. (#51) (Mattias Ellert)
- Replace obsolete -h and -p paremeters in ldap CLI tools. (#49)
(Baptiste Grenier)
- Fix deprecation warning due to log.warn. (#58) (Daniela Bauer)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwarf gwarf gwarf approved these changes

Assignees

@brucellino brucellino

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation warning for /usr/sbin/bdii-update
3 participants
@marianne013 @gwarf @brucellino