Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud integration documentation update #623

Merged
merged 25 commits into from
Feb 20, 2024
Merged

Cloud integration documentation update #623

merged 25 commits into from
Feb 20, 2024

Conversation

enolfc
Copy link
Contributor

@enolfc enolfc commented Nov 28, 2023 •
edited
Loading

Summary

Update the cloud integration documentation to:

  • Clarify requirements, reference site certification as required steps,
  • Move to catch-all cloudkeeper by default, so removing references to it
  • Remove references to legacy Check-in (pre Keycloak) as it's been deprecated
  • Improve the description of GOCDB registration

What's missing:

  • Update the accounting to not reference the appliance
  • Update the cloud-info page to move to catch-all by default

Related issue :

@enolfc
Copy link
Contributor Author

enolfc commented Nov 28, 2023

Will progress slowly with the different sections, but already as draft PR to be able to visualise and comment

@enolfc enolfc added the safe for preview Pull request vetted as safe for preview label Nov 28, 2023
@github-actions GitHub Actions
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/623

8 similar comments
@github-actions GitHub Actions
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/623

@github-actions GitHub Actions
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/623

@github-actions GitHub Actions
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/623

@github-actions GitHub Actions
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/623

@github-actions GitHub Actions
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/623

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/623

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/623

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/623

@github-actions GitHub Actions
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/623

1 similar comment
@github-actions GitHub Actions
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/623

@enolfc enolfc mentioned this pull request Jan 30, 2024
Merged
@enolfc enolfc force-pushed the cloud-integration branch from 0bb3497 to 404f3cc Compare January 30, 2024 14:14
@github-actions GitHub Actions
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/623

@enolfc
Copy link
Contributor Author

enolfc commented Jan 30, 2024

Rebased on top of #628

@enolfc enolfc mentioned this pull request Jan 30, 2024
Closed
@enolfc enolfc marked this pull request as ready for review January 30, 2024 15:30
@enolfc
Copy link
Contributor Author

enolfc commented Jan 30, 2024

Ready for review, let's have improvements in coming PRs

@enolfc enolfc requested a review from gwarf January 30, 2024 15:32
@github-actions GitHub Actions
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/623

1 similar comment
@github-actions GitHub Actions
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/623

@gwarf
Copy link
Member

gwarf commented Jan 31, 2024

Ready for review, let's have improvements in coming PRs

Would you be willing to add a list of the main changes in the PR description? It would help review them when goring through the rendered stuff, and it will also be used as the commit message when merging the PR.

@enolfc enolfc force-pushed the cloud-integration branch from 19df598 to 3d7abe9 Compare January 31, 2024 13:12
@github-actions GitHub Actions
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/623

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/623

@enolfc enolfc mentioned this pull request Feb 6, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/623

CatalinCondurache
CatalinCondurache approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@CatalinCondurache CatalinCondurache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated.

CatalinCondurache
CatalinCondurache approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@CatalinCondurache CatalinCondurache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validated

CatalinCondurache
CatalinCondurache approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@CatalinCondurache CatalinCondurache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validated

CatalinCondurache
CatalinCondurache approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@CatalinCondurache CatalinCondurache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validated

CatalinCondurache
CatalinCondurache approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@CatalinCondurache CatalinCondurache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validated

CatalinCondurache
CatalinCondurache approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@CatalinCondurache CatalinCondurache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validated

CatalinCondurache
CatalinCondurache approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@CatalinCondurache CatalinCondurache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enolfc enolfc merged commit 04c8a94 into EGI-Federation:main Feb 20, 2024
8 checks passed
@enolfc enolfc deleted the cloud-integration branch February 20, 2024 09:38
@enolfc enolfc mentioned this pull request Feb 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CatalinCondurache CatalinCondurache CatalinCondurache approved these changes

@gwarf gwarf Awaiting requested review from gwarf

Assignees
No one assigned
Labels
safe for preview Pull request vetted as safe for preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enolfc @gwarf @CatalinCondurache