Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new section to DataHub docs on How to Get Access #627

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Conversation

andrea-manzi
Copy link
Contributor

Summary


Related issue :

Copy link
Contributor

@enolfc enolfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
On a side note: @glarocca should someone else be capable of approving these section changes?

@gwarf
Copy link
Member

gwarf commented Jan 22, 2024

@andrea-manzi can you keep the new line char at the end of the file, cf https://github.com/EGI-Federation/documentation/actions/runs/7610736850/job/20724697983#step:4:128 ?

@andrea-manzi
Copy link
Contributor Author

@andrea-manzi can you keep the new line char at the end of the file, cf https://github.com/EGI-Federation/documentation/actions/runs/7610736850/job/20724697983#step:4:128 ?

fixed!

@gwarf
Copy link
Member

gwarf commented Jan 23, 2024

@glarocca please review this PR, thanks!

Copy link
Contributor

@glarocca glarocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwarf gwarf merged commit 7600716 into main Jan 23, 2024
16 checks passed
@gwarf gwarf deleted the datahub_access branch January 23, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants