Declare prettier as dependency of pre-commit hook #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruce Becker <[email protected]>
Signed-off-by: Bruce Becker <[email protected]>
Signed-off-by: Bruce Becker <[email protected]>
Signed-off-by: Bruce Becker <[email protected]>
Signed-off-by: Bruce Becker <[email protected]>
Signed-off-by: Bruce Becker <[email protected]>
Signed-off-by: Bruce Becker <[email protected]>
Signed-off-by: Bruce Becker <[email protected]>
brucellino
requested review from
enolfc,
glarocca,
gwarf and
andrea-manzi
as code owners
|
woops. Looks like I didn't discard the intermediate commits. Hope you squash this? |
Signed-off-by: Bruce Becker <[email protected]>
|
@sebastian-luna-valero ready for review. |
sebastian-luna-valero
approved these changes
Feb 27, 2024
enolfc
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds prettier as a dependency of the prettier pre-commit hook.
Turns out that the prettier configuration wants to be exported as a module, so the
additional-dependenciesin the pre-commit config don't get picked up.I've declared explicit versions of Prettier for the pre-commit hook and added a
devDependencieskey in thepackage.jsonwhich was missing.Related issue :
Closed #640