Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import mega-linter.yml #678

Merged
merged 27 commits into from
Oct 21, 2024
Merged

Import mega-linter.yml #678

merged 27 commits into from
Oct 21, 2024

Conversation

gwarf
Copy link
Member

@gwarf gwarf commented Oct 11, 2024

Import mega-linter.yml, to test mega-linter.
Include file mentioend at https://megalinter.io/latest/install-github/, but at least currently, do not commit directly to the PR, but create a new PR, to be tested/reviewed.

Fix #147.

Copy link
Contributor

@enolfc enolfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm, the linter code does not pass linting 🤔

@gwarf
Copy link
Member Author

gwarf commented Oct 13, 2024

Looking at configuring megalinter, I tend to like a lot how it's easy to identify how to configure or disable linters, there is a direct link in the test output to the megalinter documentation for a given linter, providing information on the linter home page, it's configuration and so on, such as: https://megalinter.io/v6/descriptors/copypaste_jscpd/

It's very convenient.

@gwarf
Copy link
Member Author

gwarf commented Oct 13, 2024

It finally works 🎉 :)

Copy link
Contributor

@enolfc enolfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen to the super-linter? do we keep it also?

.github/workflows/mega-linter.yml Outdated Show resolved Hide resolved
@gwarf
Copy link
Member Author

gwarf commented Oct 15, 2024

What will happen to the super-linter? do we keep it also?

I was expecting to still keep it for some time, till we have more experience and can drop one of the two

Copy link
Contributor

@enolfc enolfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's try it

@gwarf gwarf merged commit c9cb810 into EGI-Federation:main Oct 21, 2024
9 checks passed
@gwarf gwarf deleted the enable_mega_linter branch October 21, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow and consider if mega-linter could be a working/safe alternative to super-linter
2 participants