Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace static table with new cvmfs-monitor #682

Merged
merged 21 commits into from
Nov 5, 2024
Merged

Replace static table with new cvmfs-monitor #682

merged 21 commits into from
Nov 5, 2024

Conversation

sebastian-luna-valero
Copy link
Member

Summary

@jose-caballero what do you think?


Related issue :

Copy link

github-actions bot commented Nov 4, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ EDITORCONFIG editorconfig-checker 5 0 0.02s
✅ JSON jsonlint 1 0 0.15s
⚠️ JSON prettier 1 1 0.29s
✅ JSON v8r 1 0 2.01s
⚠️ MARKDOWN markdownlint 1 1 0.57s
✅ MARKDOWN markdown-link-check 1 0 4.93s
⚠️ MARKDOWN markdown-table-formatter 1 1 0.29s
✅ REPOSITORY checkov yes no 15.56s
✅ REPOSITORY gitleaks yes no 0.08s
✅ REPOSITORY git_diff yes no 0.21s
✅ REPOSITORY secretlint yes no 2.54s
✅ REPOSITORY trivy-sbom yes no 0.79s
✅ SPELL lychee 4 0 1.07s
⚠️ YAML prettier 2 1 0.31s
✅ YAML v8r 2 0 3.41s
✅ YAML yamllint 2 0 0.33s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@jose-caballero
Copy link
Contributor

Do not replace it. The table includes links to the organisations/experiments, which are not included in the monitoring.

@sebastian-luna-valero
Copy link
Member Author

ok @jose-caballero but would it be ok to link to the CVMFS monitor after the static table?

on the other hand, it would also be a good idea to show the links to the organisations/experiments in the dynamic table shown by the CVMFS monitor

@jose-caballero
Copy link
Contributor

adding the link should be ok

@jose-caballero
Copy link
Contributor

Making changes for Confluence is a nightmare. All those built-in checks are more a problem than a solution.

@gwarf
Copy link
Member

gwarf commented Nov 5, 2024

Making changes for Confluence is a nightmare. All those built-in checks are more a problem than a solution.

Confluence?

We are moving to a new check stack, and it's the one of the first real PR with it, so we have to fix some initial setup.

But we think it's helpful to have checks, even if it can need some effort indeed at some point in time :)

Copy link
Member

@gwarf gwarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I merged various fixes, to address issues with the new mega-linter setup.

@gwarf gwarf merged commit ca643dd into main Nov 5, 2024
9 checks passed
@gwarf gwarf deleted the cvmfs-monitor branch November 5, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants