Glue21 JSON #340
Merged
Glue21 JSON #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are no longer using the refresh style
Terraform Format and Style 🖌
|
Terraform Format and Style 🖌
|
Terraform Format and Style 🖌
|
brucellino
approved these changes
May 24, 2024
| export S3_BUCKET_NAME | ||
| export RCLONE_CONFIG_S3_ACL=private | ||
| export RCLONE_CONFIG_S3_NO_CHECK_BUCKET=true | ||
| rclone copy site.json "s3:$S3_BUCKET_NAME/$SITE_NAME" |
There was a problem hiding this comment.
I would add a decision record for using rclone instead of Wrangler https://developers.cloudflare.com/r2/objects/upload-objects/
There was a problem hiding this comment.
I still want to be cloudflare agnostic, rclone was the tool I was aware that could be used without much hassle.
BTW, we don't have decision records (yet). I guess if we want to get started with them, they should come as part of the PR, no?
There was a problem hiding this comment.
I'm also in favour of using well known generic and independent tools like rclone instead of cloudflare owned stuff, at least when it can be avoided and does not have a clear/decisive benefit.
There was a problem hiding this comment.
that's fine, but write a decision record for it (using e.g. https://github.com/npryce/adr-tools)
There was a problem hiding this comment.
I have made an attempt to use ADRs, somehow considering this as "Accepted" already. On the learning curve for this, so guidance on how to better use it is welcomed
There was a problem hiding this comment.
That's interesting.
It would be good to document this kind of things/guidelines/suggestions for repo management somewhere.
We could start by adding it to some internal documentation page for GitHub (like in our internal wiki).
There was a problem hiding this comment.
Added a note to https://confluence.egi.eu/display/Office/GitHub
There was a problem hiding this comment.
Thanks!
Lately I realised that we could also use the repo template to document this: https://github.com/EGI-Federation/repository-template
Terraform Format and Style 🖌
|
sebastian-luna-valero
approved these changes
May 24, 2024
Terraform Format and Style 🖌
|
Terraform Format and Style 🖌
|
Terraform Format and Style 🖌
|
brucellino
approved these changes
May 24, 2024
|
🚢 |
|
🚢 🚢 🚢 🚢 |
Ansible deployment:
|
enolfc
added a commit
to enolfc/fedcloud-catchall-operations
that referenced
this pull request
Jun 25, 2024
* Use https * Upgrade cloud-info-provider * Install rclone * Add json output and upload to S3 * Make linter happy * Remove VOs not in ops portal * Remove VO not in ops portal * Simplify management of tokens We are no longer using the refresh style * Fixes tested in the playground * Fix linter / testing issues * Fix tests * Add some docs * ADR * Linter is my friend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Publish JSON information as a way to get into a more modern information system.
The info will be published in a S3 bucket (available in the secrets of the GH Action)
Related issue :