Fix EGI logo (#49)

* Fix EGI logo

Point to the proper location

* Add pylint config

* Fix linting issues

* Do not depend on external images

* Move to rc style config

.github/linters/.python-lint

@@ -0,0 +1,19 @@
+[MAIN]
+jobs = 0
+
+[MESSAGES CONTROL]
+# add import-error to the default list
+# generated with:
+#   $ pylint --disable=import-error --generate-rcfile
+#
+disable=raw-checker-failed,
+        bad-inline-option,
+        locally-disabled,
+        file-ignored,
+        suppressed-message,
+        useless-suppression,
+        deprecated-pragma,
+        use-symbolic-message-instead,
+        use-implicit-booleaness-not-comparison-to-string,
+        use-implicit-booleaness-not-comparison-to-zero,
+        import-error

dashboard/dashy_endpoints.py

@@ -7,9 +7,9 @@
 from pathlib import Path
 from urllib import parse
 
-import defusedxml.ElementTree as ElementTree
 import requests
 import yaml
+from defusedxml import ElementTree
 
 DEFAULT_ICON = (
     "https://github.com/openstack/openstackdocstheme/blob/master"
@@ -91,6 +91,9 @@ def find_endpoints(service_type, production=True, monitored=True):
 
 
 def main():
+    """
+    Main function, generates config
+    """
     dashy_conf = {
         "pageInfo": {
             "title": "EGI Cloud Compute",
@@ -101,7 +104,7 @@ def main():
                     "path": DOCS_URL,
                 }
             ],
-            "logo": "https://egi-api.nois3.net/app/uploads/2021/11/egi-logo.svg",
+            "logo": "egi-logo.svg",
         },
         "appConfig": {
             "theme": "material",
@@ -128,18 +131,19 @@ def main():
             items.append(
                 {
                     "title": s[0],
-                    "description": "%s (%s)" % (s[3], s[4]),
-                    "icon": DEFAULT_ICON,
+                    "description": f"{s[3]} ({s[4]})",
+                    "icon": "openstack.ico",
                     "url": s[2],
                     "target": "newtab",
                 }
             )
         print(yaml.dump(dashy_conf))
-        with open(DASHY_OUTOUT, "w") as f:
+        with open(DASHY_OUTOUT, "w", encoding="utf-8") as f:
             yaml.dump(dashy_conf, f)
-    except Exception:
+    # catching anything, we don't need to be specific
+    except Exception:  # pylint: disable=broad-exception-caught
         if Path(DASHY_OUTOUT).is_file():
-            with open(DASHY_OUTOUT) as f:
+            with open(DASHY_OUTOUT, "r", encoding="utf-8") as f:
                 print(yaml.dump(yaml.safe_load(f)))
         else:
             # to-do: write in dashy_conf: "site not available at the moment"

docker-compose.yaml

@@ -41,6 +41,7 @@ services:
       - "traefik.http.routers.dashboard.tls.certresolver=myresolver"
     volumes:
       - "config:/app/public"
+      - "/fedcloud-dashboard/icons:/app/user-data/item-icons/"
     deploy:
       restart_policy:
         condition: any