Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small word change #22

Closed
wants to merge 1 commit into from
Closed

Small word change #22

wants to merge 1 commit into from

Conversation

EGI-ILM
Copy link

@EGI-ILM EGI-ILM commented Apr 26, 2022

Summary

Related issue :

@EGI-ILM EGI-ILM requested a review from a team as a code owner April 26, 2022 09:47
@enolfc
Copy link
Contributor

enolfc commented Apr 26, 2022

Tests fail and they shouldn't, opened #23

enolfc
enolfc reviewed Apr 26, 2022
View reviewed changes
Copy link
Contributor

@enolfc enolfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @EGI-ILM could you rebase with main? This should avoid having the test failing

@EGI-ILM
Copy link
Author

EGI-ILM commented Apr 26, 2022

I would like to propose other changes, so if it gets complicated perhaps it is not worth spending time on this (it is just a word, at the end of the day)

@sebastian-luna-valero
Copy link
Member

Thanks @EGI-ILM
Let's then discuss in a different PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enolfc enolfc enolfc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EGI-ILM @enolfc @sebastian-luna-valero