Change ports for motley-cue #64

sebastian-luna-valero · 2024-09-19T13:51:59Z

Summary

motley-cue uses 8080, like traefik for the dashboard. This PR moves motley-cue to a different port.

Related issue :

github-actions · 2024-09-19T13:53:32Z

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Plan 📖`success`

Show Plan

terraform
Acquiring state lock. This may take a few moments...
openstack_networking_floatingip_v2.fip: Refreshing state... [id=1a2e1285-0a20-4582-aab9-27255607a862]
openstack_compute_instance_v2.dashboard: Refreshing state... [id=7ef4dce4-495f-4c01-9ac2-cb10eca0e318]
openstack_compute_secgroup_v2.secgroup: Refreshing state... [id=47779555-2ce1-400c-ba68-d177683c7228]
openstack_compute_floatingip_associate_v2.fip: Refreshing state... [id=147.213.76.217/7ef4dce4-495f-4c01-9ac2-cb10eca0e318/]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place

Terraform will perform the following actions:

  # openstack_compute_instance_v2.dashboard will be updated in-place
  ~ resource "openstack_compute_instance_v2" "dashboard" {
        id                  = "7ef4dce4-495f-4c01-9ac2-cb10eca0e318"
        name                = "dashboard"
      ~ security_groups     = [
          + "motley-cue",
            # (2 unchanged elements hidden)
        ]
        tags                = []
        # (14 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # openstack_compute_secgroup_v2.motley will be created
  + resource "openstack_compute_secgroup_v2" "motley" {
      + description = "Open access via ssh-oidc"
      + id          = (known after apply)
      + name        = "motley-cue"
      + region      = (known after apply)

      + rule {
          + cidr        = "0.0.0.0/0"
          + from_port   = 8080
          + id          = (known after apply)
          + ip_protocol = "tcp"
          + self        = false
          + to_port     = 8080
        }
    }

Plan: 1 to add, 1 to change, 0 to destroy.

Warning: Deprecated Resource

  with openstack_compute_secgroup_v2.secgroup,
  on main.tf line 12, in resource "openstack_compute_secgroup_v2" "secgroup":
  12: resource "openstack_compute_secgroup_v2" "secgroup" {

use openstack_networking_secgroup_v2 resource instead

(and 5 more similar warnings elsewhere)

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.
Releasing state lock. This may take a few moments...

Pusher: @sebastian-luna-valero, Action: pull_request

enolfc · 2024-09-19T13:54:29Z

deployment/main.tf

@@ -6,7 +6,7 @@ resource "openstack_compute_instance_v2" "dashboard" {
  network {
    uuid = var.net_id
  }
-  security_groups = [openstack_compute_secgroup_v2.secgroup.name, "default"]
+  security_groups = ["default", "HTTP", "motley-cue"]


should we remove default?

ssh is there, should I add it to motley-cue then?

yes, I think it's better to have explicit control of the ports than to rely on groups that we don't control

done, thanks

enolfc

LGTM

… docker-compose.yaml

github-actions · 2024-09-20T07:10:45Z

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Plan 📖`success`

Show Plan

terraform
Acquiring state lock. This may take a few moments...
openstack_networking_floatingip_v2.fip: Refreshing state... [id=1a2e1285-0a20-4582-aab9-27255607a862]
openstack_compute_instance_v2.dashboard: Refreshing state... [id=7ef4dce4-495f-4c01-9ac2-cb10eca0e318]
openstack_compute_secgroup_v2.secgroup: Refreshing state... [id=47779555-2ce1-400c-ba68-d177683c7228]
openstack_compute_floatingip_associate_v2.fip: Refreshing state... [id=147.213.76.217/7ef4dce4-495f-4c01-9ac2-cb10eca0e318/]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place

Terraform will perform the following actions:

  # openstack_compute_instance_v2.dashboard will be updated in-place
  ~ resource "openstack_compute_instance_v2" "dashboard" {
        id                  = "7ef4dce4-495f-4c01-9ac2-cb10eca0e318"
        name                = "dashboard"
      ~ security_groups     = [
          + "motley-cue",
            # (2 unchanged elements hidden)
        ]
        tags                = []
        # (14 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # openstack_compute_secgroup_v2.motley will be created
  + resource "openstack_compute_secgroup_v2" "motley" {
      + description = "Open access via ssh-oidc"
      + id          = (known after apply)
      + name        = "motley-cue"
      + region      = (known after apply)

      + rule {
          + cidr        = "0.0.0.0/0"
          + from_port   = 8181
          + id          = (known after apply)
          + ip_protocol = "tcp"
          + self        = false
          + to_port     = 8181
        }
    }

Plan: 1 to add, 1 to change, 0 to destroy.

Warning: Deprecated Resource

  with openstack_compute_secgroup_v2.secgroup,
  on main.tf line 12, in resource "openstack_compute_secgroup_v2" "secgroup":
  12: resource "openstack_compute_secgroup_v2" "secgroup" {

use openstack_networking_secgroup_v2 resource instead

(and 5 more similar warnings elsewhere)

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.
Releasing state lock. This may take a few moments...

Pusher: @sebastian-luna-valero, Action: pull_request

github-actions · 2024-09-20T07:14:03Z

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Plan 📖`success`

Show Plan

terraform
Acquiring state lock. This may take a few moments...
openstack_networking_floatingip_v2.fip: Refreshing state... [id=1a2e1285-0a20-4582-aab9-27255607a862]
openstack_compute_secgroup_v2.secgroup: Refreshing state... [id=47779555-2ce1-400c-ba68-d177683c7228]
openstack_compute_instance_v2.dashboard: Refreshing state... [id=7ef4dce4-495f-4c01-9ac2-cb10eca0e318]
openstack_compute_floatingip_associate_v2.fip: Refreshing state... [id=147.213.76.217/7ef4dce4-495f-4c01-9ac2-cb10eca0e318/]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place

Terraform will perform the following actions:

  # openstack_compute_instance_v2.dashboard will be updated in-place
  ~ resource "openstack_compute_instance_v2" "dashboard" {
        id                  = "7ef4dce4-495f-4c01-9ac2-cb10eca0e318"
        name                = "dashboard"
      ~ security_groups     = [
          + "motley-cue",
            # (2 unchanged elements hidden)
        ]
        tags                = []
        # (14 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # openstack_compute_secgroup_v2.motley will be created
  + resource "openstack_compute_secgroup_v2" "motley" {
      + description = "Open access via ssh-oidc"
      + id          = (known after apply)
      + name        = "motley-cue"
      + region      = (known after apply)

      + rule {
          + cidr        = "0.0.0.0/0"
          + from_port   = 8181
          + id          = (known after apply)
          + ip_protocol = "tcp"
          + self        = false
          + to_port     = 8181
        }
    }

Plan: 1 to add, 1 to change, 0 to destroy.

Warning: Deprecated Resource

  with openstack_compute_secgroup_v2.secgroup,
  on main.tf line 12, in resource "openstack_compute_secgroup_v2" "secgroup":
  12: resource "openstack_compute_secgroup_v2" "secgroup" {

use openstack_networking_secgroup_v2 resource instead

(and 5 more similar warnings elsewhere)

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

Pusher: @sebastian-luna-valero, Action: pull_request

enolfc

just 2 minor things

README.md

enolfc · 2024-09-20T07:18:55Z

deployment/main.tf

@@ -6,7 +6,7 @@ resource "openstack_compute_instance_v2" "dashboard" {
  network {
    uuid = var.net_id
  }
-  security_groups = [openstack_compute_secgroup_v2.secgroup.name, "default"]
+  security_groups = ["default", "HTTP", "motley-cue"]


yes, I think it's better to have explicit control of the ports than to rely on groups that we don't control

Co-authored-by: Enol Fernández <[email protected]>

github-actions · 2024-09-20T07:24:01Z

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Plan 📖`success`

Show Plan

terraform
Acquiring state lock. This may take a few moments...
openstack_networking_floatingip_v2.fip: Refreshing state... [id=1a2e1285-0a20-4582-aab9-27255607a862]
openstack_compute_instance_v2.dashboard: Refreshing state... [id=7ef4dce4-495f-4c01-9ac2-cb10eca0e318]
openstack_compute_secgroup_v2.secgroup: Refreshing state... [id=47779555-2ce1-400c-ba68-d177683c7228]
openstack_compute_floatingip_associate_v2.fip: Refreshing state... [id=147.213.76.217/7ef4dce4-495f-4c01-9ac2-cb10eca0e318/]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place

Terraform will perform the following actions:

  # openstack_compute_instance_v2.dashboard will be updated in-place
  ~ resource "openstack_compute_instance_v2" "dashboard" {
        id                  = "7ef4dce4-495f-4c01-9ac2-cb10eca0e318"
        name                = "dashboard"
      ~ security_groups     = [
          + "motley-cue",
            # (2 unchanged elements hidden)
        ]
        tags                = []
        # (14 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # openstack_compute_secgroup_v2.motley will be created
  + resource "openstack_compute_secgroup_v2" "motley" {
      + description = "Open access via ssh-oidc"
      + id          = (known after apply)
      + name        = "motley-cue"
      + region      = (known after apply)

      + rule {
          + cidr        = "0.0.0.0/0"
          + from_port   = 8181
          + id          = (known after apply)
          + ip_protocol = "tcp"
          + self        = false
          + to_port     = 8181
        }
    }

Plan: 1 to add, 1 to change, 0 to destroy.

Warning: Deprecated Resource

  with openstack_compute_secgroup_v2.secgroup,
  on main.tf line 12, in resource "openstack_compute_secgroup_v2" "secgroup":
  12: resource "openstack_compute_secgroup_v2" "secgroup" {

use openstack_networking_secgroup_v2 resource instead

(and 5 more similar warnings elsewhere)

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.
Releasing state lock. This may take a few moments...

Pusher: @sebastian-luna-valero, Action: pull_request

…into ports

github-actions · 2024-09-20T07:26:10Z

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Plan 📖`success`

Show Plan

terraform
Acquiring state lock. This may take a few moments...
openstack_networking_floatingip_v2.fip: Refreshing state... [id=1a2e1285-0a20-4582-aab9-27255607a862]
openstack_compute_secgroup_v2.secgroup: Refreshing state... [id=47779555-2ce1-400c-ba68-d177683c7228]
openstack_compute_instance_v2.dashboard: Refreshing state... [id=7ef4dce4-495f-4c01-9ac2-cb10eca0e318]
openstack_compute_floatingip_associate_v2.fip: Refreshing state... [id=147.213.76.217/7ef4dce4-495f-4c01-9ac2-cb10eca0e318/]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place

Terraform will perform the following actions:

  # openstack_compute_instance_v2.dashboard will be updated in-place
  ~ resource "openstack_compute_instance_v2" "dashboard" {
        id                  = "7ef4dce4-495f-4c01-9ac2-cb10eca0e318"
        name                = "dashboard"
      ~ security_groups     = [
          - "default",
          + "motley-cue",
            # (1 unchanged element hidden)
        ]
        tags                = []
        # (14 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # openstack_compute_secgroup_v2.motley will be created
  + resource "openstack_compute_secgroup_v2" "motley" {
      + description = "Open access via ssh-oidc"
      + id          = (known after apply)
      + name        = "motley-cue"
      + region      = (known after apply)

      + rule {
          + cidr        = "0.0.0.0/0"
          + from_port   = 22
          + id          = (known after apply)
          + ip_protocol = "tcp"
          + self        = false
          + to_port     = 22
        }
      + rule {
          + cidr        = "0.0.0.0/0"
          + from_port   = 8181
          + id          = (known after apply)
          + ip_protocol = "tcp"
          + self        = false
          + to_port     = 8181
        }
    }

Plan: 1 to add, 1 to change, 0 to destroy.

Warning: Deprecated Resource

  with openstack_compute_secgroup_v2.secgroup,
  on main.tf line 12, in resource "openstack_compute_secgroup_v2" "secgroup":
  12: resource "openstack_compute_secgroup_v2" "secgroup" {

use openstack_networking_secgroup_v2 resource instead

(and 5 more similar warnings elsewhere)

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.
Releasing state lock. This may take a few moments...

Pusher: @sebastian-luna-valero, Action: pull_request

github-actions · 2024-09-20T07:34:28Z

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Plan 📖`success`

Show Plan

terraform
Acquiring state lock. This may take a few moments...
openstack_networking_floatingip_v2.fip: Refreshing state... [id=1a2e1285-0a20-4582-aab9-27255607a862]
openstack_compute_secgroup_v2.secgroup: Refreshing state... [id=47779555-2ce1-400c-ba68-d177683c7228]
openstack_compute_instance_v2.dashboard: Refreshing state... [id=7ef4dce4-495f-4c01-9ac2-cb10eca0e318]
openstack_compute_floatingip_associate_v2.fip: Refreshing state... [id=147.213.76.217/7ef4dce4-495f-4c01-9ac2-cb10eca0e318/]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place

Terraform will perform the following actions:

  # openstack_compute_instance_v2.dashboard will be updated in-place
  ~ resource "openstack_compute_instance_v2" "dashboard" {
        id                  = "7ef4dce4-495f-4c01-9ac2-cb10eca0e318"
        name                = "dashboard"
      ~ security_groups     = [
          - "default",
          + "motley-cue",
            # (1 unchanged element hidden)
        ]
        tags                = []
        # (14 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # openstack_compute_secgroup_v2.motley will be created
  + resource "openstack_compute_secgroup_v2" "motley" {
      + description = "Open access via ssh-oidc"
      + id          = (known after apply)
      + name        = "motley-cue"
      + region      = (known after apply)

      + rule {
          + cidr        = "0.0.0.0/0"
          + from_port   = 22
          + id          = (known after apply)
          + ip_protocol = "tcp"
          + self        = false
          + to_port     = 22
        }
      + rule {
          + cidr        = "0.0.0.0/0"
          + from_port   = 8181
          + id          = (known after apply)
          + ip_protocol = "tcp"
          + self        = false
          + to_port     = 8181
        }
    }

Plan: 1 to add, 1 to change, 0 to destroy.

Warning: Deprecated Resource

  with openstack_compute_secgroup_v2.secgroup,
  on main.tf line 12, in resource "openstack_compute_secgroup_v2" "secgroup":
  12: resource "openstack_compute_secgroup_v2" "secgroup" {

use openstack_networking_secgroup_v2 resource instead

(and 5 more similar warnings elsewhere)

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.
Releasing state lock. This may take a few moments...

Pusher: @sebastian-luna-valero, Action: pull_request

enolfc

👍

open ports for motley-cue

ebd73ee

sebastian-luna-valero requested a review from a team as a code owner September 19, 2024 13:52

enolfc reviewed Sep 19, 2024

View reviewed changes

enolfc approved these changes Sep 19, 2024

View reviewed changes

sebastian-luna-valero added 3 commits September 20, 2024 08:53

revert bf972a1 and apply prettier

8fbdc29

add DASHBOARD_HOSTNAME back to traefik.http.routers.dashboard.rule in…

9c6772b

… docker-compose.yaml

move motley-cue to port 8181

bd45d01

sebastian-luna-valero changed the title ~~Open ports for motley-cue~~ Change ports for motley-cue Sep 20, 2024

linting

93b0e19

enolfc requested changes Sep 20, 2024

View reviewed changes

sebastian-luna-valero and others added 2 commits September 20, 2024 09:22

Dump DASHBOARD_HOSTNAME to .env file

a92c772

Co-authored-by: Enol Fernández <[email protected]>

add SSH explicitly to the motley-cue security group

31f095b

Merge branch 'ports' of github.com:EGI-Federation/fedcloud-dashboard …

e6a1656

…into ports

we should be using handlers

bdaf963

enolfc approved these changes Sep 20, 2024

View reviewed changes

enolfc merged commit f47fc40 into main Sep 20, 2024
5 checks passed

sebastian-luna-valero deleted the ports branch September 20, 2024 10:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change ports for motley-cue #64

Change ports for motley-cue #64

sebastian-luna-valero commented Sep 19, 2024 •

edited

Loading

github-actions bot commented Sep 19, 2024

enolfc Sep 19, 2024

sebastian-luna-valero Sep 19, 2024

enolfc Sep 20, 2024

sebastian-luna-valero Sep 20, 2024

enolfc left a comment

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

enolfc left a comment

enolfc Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Sep 20, 2024

enolfc left a comment

Change ports for motley-cue #64

Change ports for motley-cue #64

Conversation

sebastian-luna-valero commented Sep 19, 2024 • edited Loading

Summary

github-actions bot commented Sep 19, 2024

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Plan 📖success

enolfc Sep 19, 2024

Choose a reason for hiding this comment

sebastian-luna-valero Sep 19, 2024

Choose a reason for hiding this comment

enolfc Sep 20, 2024

Choose a reason for hiding this comment

sebastian-luna-valero Sep 20, 2024

Choose a reason for hiding this comment

enolfc left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 20, 2024

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Plan 📖success

github-actions bot commented Sep 20, 2024

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Plan 📖success

enolfc left a comment

Choose a reason for hiding this comment

enolfc Sep 20, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 20, 2024

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Plan 📖success

github-actions bot commented Sep 20, 2024

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Plan 📖success

github-actions bot commented Sep 20, 2024

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Plan 📖success

enolfc left a comment

Choose a reason for hiding this comment

sebastian-luna-valero commented Sep 19, 2024 •

edited

Loading

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Plan 📖`success`

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Plan 📖`success`

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Plan 📖`success`

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Plan 📖`success`

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Plan 📖`success`

Terraform Format and Style 🖌`success`

Terraform Initialization ⚙️`success`

Terraform Plan 📖`success`