Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back the release checks #2

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
name: Build

on:
Expand Down Expand Up @@ -36,7 +37,7 @@ jobs:
python -m pip install .[test]

jupyter labextension list
jupyter labextension list 2>&1 | grep -ie "resource_warning.*OK"
jupyter labextension list 2>&1 | grep -ie "notebooks-resource-warning.*OK"
python -m jupyterlab.browser_check

- name: Package the extension
Expand All @@ -45,13 +46,13 @@ jobs:

pip install build
python -m build
pip uninstall -y "resource_warning" jupyterlab
pip uninstall -y "notebooks-resource-warning" jupyterlab

- name: Upload extension packages
uses: actions/upload-artifact@v4
with:
name: extension-artifacts
path: dist/resource_warning*
path: dist/notebooks-resource-warning*
if-no-files-found: error

test_isolated:
Expand All @@ -74,11 +75,11 @@ jobs:
sudo rm -rf $(which node)
sudo rm -rf $(which node)

pip install "jupyterlab>=4.0.0,<5" resource_warning*.whl
pip install "jupyterlab>=4.0.0,<5" notebooks-resource-warning*.whl


jupyter labextension list
jupyter labextension list 2>&1 | grep -ie "resource_warning.*OK"
jupyter labextension list 2>&1 | grep -ie "notebooks-resource-warning.*OK"
python -m jupyterlab.browser_check --no-browser-test


Expand Down
30 changes: 30 additions & 0 deletions .github/workflows/check-release.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
name: Check Release
on:
push:
branches: ["main"]
pull_request:
branches: ["*"]

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
check_release:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Base Setup
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
- name: Check Release
uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2
with:

token: ${{ secrets.GITHUB_TOKEN }}

- name: Upload Distributions
uses: actions/upload-artifact@v4
with:
name: resource_warning-releaser-dist-${{ github.run_number }}
path: .jupyter_releaser_checkout/dist
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "resource_warning",
"name": "notebooks-resource-warning",
"version": "0.1.0",
"description": "A JupyterLab extension that shows a notification when reaching warning level of resource consumption (memory).",
"keywords": [
Expand Down
62 changes: 31 additions & 31 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4522,6 +4522,37 @@ __metadata:
languageName: node
linkType: hard

"notebooks-resource-warning@workspace:.":
version: 0.0.0-use.local
resolution: "notebooks-resource-warning@workspace:."
dependencies:
"@jupyter-server/resource-usage": ^1.1.0
"@jupyterlab/application": ^4.0.0
"@jupyterlab/builder": ^4.0.0
"@types/json-schema": ^7.0.11
"@types/react": ^18.0.26
"@types/react-addons-linked-state-mixin": ^0.14.22
"@typescript-eslint/eslint-plugin": ^6.1.0
"@typescript-eslint/parser": ^6.1.0
css-loader: ^6.7.1
eslint: ^8.36.0
eslint-config-prettier: ^8.8.0
eslint-plugin-prettier: ^5.0.0
npm-run-all: ^4.1.5
prettier: 3.3.3
rimraf: ^5.0.1
source-map-loader: ^1.0.2
style-loader: ^3.3.1
stylelint: ^15.10.1
stylelint-config-recommended: ^13.0.0
stylelint-config-standard: ^34.0.0
stylelint-csstree-validator: ^3.0.0
stylelint-prettier: ^4.0.0
typescript: ~5.0.2
yjs: ^13.5.0
languageName: unknown
linkType: soft

"npm-run-all@npm:^4.1.5":
version: 4.1.5
resolution: "npm-run-all@npm:4.1.5"
Expand Down Expand Up @@ -5144,37 +5175,6 @@ __metadata:
languageName: node
linkType: hard

"resource_warning@workspace:.":
version: 0.0.0-use.local
resolution: "resource_warning@workspace:."
dependencies:
"@jupyter-server/resource-usage": ^1.1.0
"@jupyterlab/application": ^4.0.0
"@jupyterlab/builder": ^4.0.0
"@types/json-schema": ^7.0.11
"@types/react": ^18.0.26
"@types/react-addons-linked-state-mixin": ^0.14.22
"@typescript-eslint/eslint-plugin": ^6.1.0
"@typescript-eslint/parser": ^6.1.0
css-loader: ^6.7.1
eslint: ^8.36.0
eslint-config-prettier: ^8.8.0
eslint-plugin-prettier: ^5.0.0
npm-run-all: ^4.1.5
prettier: 3.3.3
rimraf: ^5.0.1
source-map-loader: ^1.0.2
style-loader: ^3.3.1
stylelint: ^15.10.1
stylelint-config-recommended: ^13.0.0
stylelint-config-standard: ^34.0.0
stylelint-csstree-validator: ^3.0.0
stylelint-prettier: ^4.0.0
typescript: ~5.0.2
yjs: ^13.5.0
languageName: unknown
linkType: soft

"reusify@npm:^1.0.4":
version: 1.0.4
resolution: "reusify@npm:1.0.4"
Expand Down
Loading