Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme 2017 #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Theme 2017 #6

wants to merge 2 commits into from

Conversation

ct-martin
Copy link

  • Newer theme! Uses HTML5 Boilerplate & Bootstrap and is responsive in addition to looking better
  • Included some custom fixes for Bootstrap
  • Built-in Font Awesome for cool icons
  • Nice .text-egs-orange and .bg-egs-orange for your EGS-orange-colored needs
  • Revamped a bunch of pages
  • Replaced the carousel with the bootstrap one since it's already there and also looks nicer
  • Replaced the awful usage of tables to format things with proper, responsive parts that look nice (looking at you board util and upcoming [event]s)
  • Made images responsive across the whole site
  • Removed old theme & leftovers
  • Removed double importing of the old stylesheet and scripts
  • General cleaning of HTML, including some violations (such as duplicate IDs)
  • Added self to README.md (but not site footer, I'll leave that choice to you)

Demo can be found at https://apps.ctmartin.me/egs/EGS-Website/web/ - but note that you need to manually change the URL (ex: .../web/about)

- Newer theme! Uses HTML5 Boilerplate & Bootstrap and is responsive in addition to looking better
- Removed old theme & leftovers
- Included some custom fixes for Bootstrap
- Built-in Font Awesome for cool icons
- Nice .text-egs-orange and .bg-egs-orange for your EGS-orange-colored needs
- Revamped a bunch of pages
- Replaced the carousel with the bootstrap one since it's already there and also looks nicer
- Replaced the awful usage of tables to format things with proper, responsive parts that look nice (looking at you board util and upcoming [event]s)
- Made images responsive across the whole site
- Removed double importing of the old stylesheet and scripts
- General cleaning of HTML, including some violations (such as duplicate IDs)
- Added self to README.md (but not site footer, I'll leave that choice to you)
@ct-martin
Copy link
Author

BTW, build looks like it failed due to config error?

@Chris-Bitler
Copy link
Member

Yeah, travis is having some issues.

I've put this code up at http://beta.egsrit.com to get an idea of what it looks like. There are a few issues that I've found so far, but overall I'm liking it.

Few of the issues:

  • LAN title on the LAN of the Wild page is off center, which should be an easy fix
  • The banners for the communities are all left-aligned, which seems kind of odd, leaving a bit of empty space at the top and a good amount of empty space at the right side

I've also given the link to the rest of the EGS Eboard to review the layout and give any suggestions/comments. :)

- Fixed centering of Community pages
- Centered LAN of the Wild header
- Fixed Membership page being whited out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants