Skip to content
This repository has been archived by the owner on May 4, 2023. It is now read-only.

Add Wii Theme #20

Merged
merged 3 commits into from
Aug 30, 2022
Merged

Add Wii Theme #20

merged 3 commits into from
Aug 30, 2022

Conversation

OT-Archmage
Copy link
Contributor

Wii Theme

Insert a link to the GitHub repository of the pack.

Checklist

Failure to complete this checklist or deleting boxes from the checklist will result in the closing of your pull request unless this is a pack update. Please write any comments regarding this checklist at the bottom of your pull request.

Check every box.

  • I am the original author of this pack or have permission from the original author to make this pull request.
  • All copyright of this pack's contents belong to the listed author or is cited in the description and repository linked above.
  • This theme works properly on the latest versions of SteamOS for Steam Deck, decky-loader and SDH-AudioLoader.
  • This pack is under 10MB in size and uses the least disk space possible.
  • This pack is safe for work and does not contain any sexual, drug-related, or profane content.
  • This pack does not contain loud, distorted, or otherwise bad faith sound files.
  • This pack is only for either music or sounds and only adds or modifies the intended sound files.

Copy link
Owner

@EMERALD0874 EMERALD0874 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sound for starting a game is pulled from starting the console, not a game. Is there any chance you could replace it with the proper sound? This would ensure accuracy and avoid overlap with a Wii menu music pack in the future. Other than that, everything looks and sounds great! Thank you for making this!

@OT-Archmage
Copy link
Contributor Author

I was actually working on an accompanying music pack using track 2 from the khinsider Wii Menu Gamerip album. The reason I made that sound the "launch game" sound rather than including it in the music pack is because it only plays once at the start and doesn't fit into a proper loop, unless the plugin has a way to have an intro track that transitions into a separate looping track.

I get what you mean about accuracy though, so I've changed the sound like you suggested.

@OT-Archmage
Copy link
Contributor Author

@EMERALD0874
Copy link
Owner

unless the plugin has a way to have an intro track that transitions into a separate looping track.

This is a great idea. I have created DeckThemes/SDH-AudioLoader#11 to help with this implementation.

Copy link
Owner

@EMERALD0874 EMERALD0874 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EMERALD0874 EMERALD0874 merged commit 5a69852 into EMERALD0874:main Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants