Reference to shared_ptr can be invalidated by completion of push_tran…

…saction. Create a local copy of transaction_metadata shared_ptr to keep alive until end of scope.
EOSIO · May 30, 2019 · 2b24e2b · 2b24e2b
1 parent 9d8645c
commit 2b24e2b
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/plugins/producer_plugin/producer_plugin.cpp b/plugins/producer_plugin/producer_plugin.cpp
@@ -1208,7 +1208,7 @@ producer_plugin_impl::start_block_result producer_plugin_impl::start_block() {
 
                   if( preprocess_deadline <= fc::time_point::now() ) exhausted = true;
                   if( exhausted ) break;
-                  const auto& trx = itr->second;
+                  const transaction_metadata_ptr trx = itr->second;
                   auto category = calculate_transaction_category(trx);
                   if (category == tx_category::EXPIRED ||
                      (category == tx_category::UNEXPIRED_UNPERSISTED && _producers.empty()))