merge最新代码 #12
Open
merge最新代码 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winlin
reviewed
Aug 21, 2018
| "casename": "Testcase 01_get_request", | ||
| "pre_call": "echo 'This is called BEFORE cmdline call'", | ||
| "post_call": "echo 'This is called AFTER cmdline call'", | ||
| "stoponfail": "true", |
There was a problem hiding this comment.
please add description to describe the case of the script
winlin
reviewed
Aug 21, 2018
| #process = Popen(cmdline, stdout=PIPE, stderr=PIPE,shell=True) | ||
| #time.sleep(1) | ||
| #cmdlinel = f"cleos get account {newaccount}" | ||
| #process = Popen(cmdlinel, stdout=PIPE, stderr=PIPE,shell=True) |
There was a problem hiding this comment.
unused code should be removed
There was a problem hiding this comment.
newaccount 这个功能要不要测试呢？如果生成无用的帐号没什么意义。
| #reprod | ||
| newaccount= params["newaccount"] | ||
| bppubkey = params["bppubkey"] | ||
| cmdline = f"cleos system regproducer {newaccount} {bppubkey} https://www.xxx.com 900" |
| return True | ||
|
|
||
| if __name__ == '__main__': | ||
| sys.exit( 0 if main() else 1) |
There was a problem hiding this comment.
after you have finished your code, please run python3 startmonster.py to check the script works well
There was a problem hiding this comment.
i used python3.6，because httpapi/ used python3.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.