Skip to content

Commit

Permalink
upload_assets update TODO note about always-upload feature #5 #22
Browse files Browse the repository at this point in the history
  • Loading branch information
soxofaan committed Jul 25, 2024
1 parent df4fd8f commit 586bc8d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions qa/tools/apex_algorithm_qa_tools/pytest_upload_assets.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def test_dummy(upload_assets, tmp_path):


def pytest_addoption(parser: pytest.Parser):
# TODO: option to always upload (also on success).
# TODO #22: option to always upload (also on success).
parser.addoption(
"--upload-assets-run-id",
metavar="RUNID",
Expand Down Expand Up @@ -111,7 +111,7 @@ def pytest_runtest_logstart(self, nodeid):
self.collected_assets = {}

def pytest_runtest_logreport(self, report: pytest.TestReport):
# TODO: option to upload on other outcome as well?
# TODO #22: option to upload on other outcome as well?
if report.when == "call" and report.outcome == "failed":
# TODO: what to do when upload fails?
uploaded = self._upload(nodeid=report.nodeid)
Expand Down

0 comments on commit 586bc8d

Please sign in to comment.