-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cam6_4_062: Phase 2 of GW development #1117
cam6_4_062: Phase 2 of GW development #1117
Conversation
Merge pull request ESCOMP#1147 from jedwards4b/timestamp_in_rpointer_name
Merge pull request ESCOMP#1203 from brian-eaton/misc06
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might have a few more changes, but submitting it for now
!!$OMP PARALLEL NUM_THREADS(horz_num_threads), DEFAULT(SHARED), PRIVATE(nets,nete,hybrid,ie,ncols,frontgf_thr,frontga_thr) | ||
! hybrid = config_thread_region(par,'horizontal') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have these been tested?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I realize that it appears to be a bunch of requests, but the vast majority are just code-cleanup or documentation requests. Of course if you have any questions or concerns with any of my questions or suggestions just let me know. Thanks!
|
||
<entry id="movmtn_plaunch" type="real" category="gw_drag" | ||
group="gw_drag_nl" valid_values="" > | ||
Global launch level (Pa) for moving mtns. If neg do something else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modify this comment as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great to me now!
Fix heating depth bug for gravity wave parameterization
Merge pull request ESCOMP#1117 from JulioTBacmeister/gw_devel_b00 cam6_4_062: Phase 2 of GW development ESCOMP commit: 834379d
Closes #1115