Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam6_4_062: Phase 2 of GW development #1117

Merged
merged 25 commits into from
Feb 7, 2025

Conversation

cacraigucar
Copy link
Collaborator

Closes #1115

@cacraigucar cacraigucar added enhancement New feature or request answer changing answer changing tag CoupledEval3 chill labels Aug 5, 2024
@cacraigucar cacraigucar marked this pull request as draft August 5, 2024 16:09
@cacraigucar cacraigucar marked this pull request as ready for review January 27, 2025 21:38
Copy link
Collaborator Author

@cacraigucar cacraigucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have a few more changes, but submitting it for now

Comment on lines 136 to 137
!!$OMP PARALLEL NUM_THREADS(horz_num_threads), DEFAULT(SHARED), PRIVATE(nets,nete,hybrid,ie,ncols,frontgf_thr,frontga_thr)
! hybrid = config_thread_region(par,'horizontal')
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have these been tested?

src/dynamics/se/gravity_waves_sources.F90 Outdated Show resolved Hide resolved
bld/build-namelist Outdated Show resolved Hide resolved
bld/namelist_files/namelist_definition.xml Outdated Show resolved Hide resolved
src/physics/cam/gw_drag.F90 Outdated Show resolved Hide resolved
src/physics/cam/gw_movmtn.F90 Outdated Show resolved Hide resolved
src/physics/cam/gw_movmtn.F90 Outdated Show resolved Hide resolved
src/physics/cam/gw_movmtn.F90 Outdated Show resolved Hide resolved
src/physics/cam/gw_movmtn.F90 Outdated Show resolved Hide resolved
src/dynamics/se/dp_coupling.F90 Show resolved Hide resolved
@cacraigucar cacraigucar changed the title Phase 2 of GW development cam6_4_062: Phase 2 of GW development Jan 28, 2025
@nusbaume nusbaume self-requested a review February 3, 2025 16:17
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I realize that it appears to be a bunch of requests, but the vast majority are just code-cleanup or documentation requests. Of course if you have any questions or concerns with any of my questions or suggestions just let me know. Thanks!

bld/namelist_files/namelist_defaults_cam.xml Outdated Show resolved Hide resolved
bld/namelist_files/namelist_definition.xml Outdated Show resolved Hide resolved
bld/namelist_files/namelist_definition.xml Outdated Show resolved Hide resolved
bld/namelist_files/namelist_definition.xml Outdated Show resolved Hide resolved
src/dynamics/se/dp_coupling.F90 Show resolved Hide resolved
src/physics/cam/gw_movmtn.F90 Outdated Show resolved Hide resolved
src/physics/cam/gw_movmtn.F90 Outdated Show resolved Hide resolved
src/physics/cam/gw_movmtn.F90 Outdated Show resolved Hide resolved
src/physics/cam/gw_rdg.F90 Outdated Show resolved Hide resolved
src/physics/cam/gw_rdg.F90 Show resolved Hide resolved
bld/namelist_files/namelist_definition.xml Outdated Show resolved Hide resolved

<entry id="movmtn_plaunch" type="real" category="gw_drag"
group="gw_drag_nl" valid_values="" >
Global launch level (Pa) for moving mtns. If neg do something else
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify this comment as above

bld/namelist_files/namelist_definition.xml Outdated Show resolved Hide resolved
src/physics/cam/gw_common.F90 Outdated Show resolved Hide resolved
src/physics/cam/gw_drag.F90 Outdated Show resolved Hide resolved
src/physics/cam/gw_drag.F90 Outdated Show resolved Hide resolved
src/physics/cam/gw_drag.F90 Outdated Show resolved Hide resolved
src/physics/cam/gw_rdg.F90 Show resolved Hide resolved
bld/namelist_files/namelist_defaults_cam.xml Outdated Show resolved Hide resolved
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great to me now!

Fix heating depth bug for gravity wave parameterization
@cacraigucar cacraigucar merged commit 834379d into ESCOMP:cam_development Feb 7, 2025
2 checks passed
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Feb 13, 2025
Merge pull request ESCOMP#1117 from JulioTBacmeister/gw_devel_b00

cam6_4_062: Phase 2 of GW development

ESCOMP commit: 834379d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answer changing answer changing tag chill CoupledEval3 enhancement New feature or request
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

4 participants