Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stream_definition_datm.xml to include longer time period in files #277

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

TeaganKing
Copy link
Collaborator

@TeaganKing TeaganKing commented May 9, 2024

Description of changes

This PR includes files containing longer time periods (1849-2101) in datm/cime_config/stream_definition_datm.xml for the following SSP370 streams: co2tseries.SSP3-7.0 and presaero.SSP3-7.0

Contributors other than yourself, if any: @wwieder , @ekluzek , @samsrabin

CDEPS Issues Fixed: #246

Are there dependencies on other component PRs (if so list): No

Are changes expected to change answers: No, the files are just extended but contain the same data for the later part of the time period

Any User Interface Changes (namelist or namelist defaults changes): No

Testing performed (e.g. aux_cdeps, CESM prealpha, etc):

Hashes used for testing:

@TeaganKing TeaganKing mentioned this pull request May 9, 2024
@TeaganKing TeaganKing self-assigned this May 9, 2024
Copy link

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TeaganKing this looks good to me, thanks!

datm/cime_config/stream_definition_datm.xml Show resolved Hide resolved
@mvertens mvertens changed the title Update stream_definition_datm.xml to include longer files Update stream_definition_datm.xml to include longer time period in files May 10, 2024
@TeaganKing TeaganKing removed the request for review from samsrabin May 22, 2024 15:58
@TeaganKing
Copy link
Collaborator Author

This is ready for review; @slevis-lmwg has already reviewed the changes, and I just updated the PR to ensure the branch is up to date. It looks like this may need a review from someone with write access in addition to the review from Sam.

@TeaganKing TeaganKing requested a review from billsacks June 24, 2024 17:44
Copy link
Member

@billsacks billsacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @TeaganKing !

@billsacks
Copy link
Member

@TeaganKing (and @slevis-lmwg or others): Should we bring this in now, or is there some reason to wait to merge it?

@TeaganKing
Copy link
Collaborator Author

Thanks @billsacks . I'm not aware of any reason to wait to merge this.

@billsacks billsacks merged commit 9b73292 into ESCOMP:main Jun 24, 2024
1 check passed
@TeaganKing TeaganKing deleted the default_files branch June 24, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ssp370 default aerosol file starts in 2014
3 participants