Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: Fix so that the "rel:<namelist_var>" option can be used for input_pathname in namelist definition files #4739

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ekluzek
Copy link
Contributor

@ekluzek ekluzek commented Jan 18, 2025

Fix the relative path option for input_pathname in namelist definition files. This now allows using a "rel:" prefix for it.
The usage is to use that prefix in front of a namelist variable name that will be used as the relative path for the pathname of the file.

So for example (if rundir is added to the namelist definiton file to be from the XML variable RUNDIR), you can do something like:

<input_pathname>rel:rundir</input_pathname>

Which will then prepend the filename for that variable with the RUNDIR directory, and also add it to the relevant .input_data_list file so that filename will be checked for existence.

Test suite: So far only tested a single case with a CMEPS PR that includes a namelist item with a rel: option for input_pathname
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #4738
User interface changes?: No

Update gh-pages html (Y/N)?: No

I do plan on doing more testing, so I'll report more on what I do later. But I will also note that this is pretty isolated, so unlikely to cause problems. And it's only loosening a XSD check so can't cause problems with existing things that work. I would like to add some type of test that would catch this type of problem, but I haven't figured out how to do that yet. So I'd love to hear suggestions on that.

@ekluzek ekluzek added Responsibility: CESM Responsibility to manage and accomplish this issue is through CESM ty: Bug Fix tp: config labels Jan 18, 2025
@ekluzek ekluzek changed the title Fix so that the "rel:<namelist_var>" option can be used for input_pathname in namelist definition files [WIP]: Fix so that the "rel:<namelist_var>" option can be used for input_pathname in namelist definition files Jan 18, 2025
@ekluzek ekluzek added the Responsibility: CTSM Responsibility to manage and accomplish this issue is the CTSM Software group label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Responsibility: CESM Responsibility to manage and accomplish this issue is through CESM Responsibility: CTSM Responsibility to manage and accomplish this issue is the CTSM Software group tp: config ty: Bug Fix
Projects
None yet
1 participant