Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up grammars ending reduced arrays #105

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

barsnick
Copy link
Contributor

Describe your changes

Arrays which are reduced in size by decision of the codec generator or its configuration used an extra "buffer" element, in order to provide continuation grammars beyond the premature ends of reduced arrays.

This cleans these extra grammars up by:

  • dropping them for loops,
  • providing proper comments for arrays reduced to a single element

The grammars are now clean, and the code generation understands blocks which are in place to provide the "pre-final" grammar of the arrays.

Issue ticket number and link

#91

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

…nded arrays

All unbounded arrays are restricted to single particles, unless configured
differently.

Signed-off-by: Moritz Barsnick <[email protected]>
This is informative and useful for understanding modified array grammars for
reduced arrays, including those reduced to single particles.

Signed-off-by: Moritz Barsnick <[email protected]>
Reduced arrays used an extra "buffer" element, to provide continuation
grammars beyond the premature ends of reduced arrays.

This cleans these up by:
- dropping them for loops,
- providing proper comments for arrays reduced to a single element

The grammars are now clean, and the code generation understands blocks which
are in place to provide the "pre-final" grammar of the arrays.

Signed-off-by: Moritz Barsnick <[email protected]>
Signed-off-by: Moritz Barsnick <[email protected]>
@barsnick barsnick requested a review from SebaLukas January 30, 2025 11:46
@barsnick barsnick requested a review from chausGit as a code owner January 30, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant