chore(loopbackRpcIssuer): reduced random wait #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 19, 2024
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
lukas-mertens
force-pushed
the
spr/main/fdcfca23
branch
from
38c1e07 to
f05e98d
Compare
lukas-mertens
force-pushed
the
spr/main/4c4eb3f1
branch
from
5e9f2c2 to
0580186
Compare
|
Maybe I do not understand this correctly, as I haven't worked with the admin panel code so far, but (if that was your intention) you did not change the duration of the random wait, but the return value of the get_rpc_timeout function. To change the duration, you'd have to edit |
|
@nzbr Wow. Good catch. What I did there didn't make any sense at all. |
lukas-mertens
force-pushed
the
spr/main/fdcfca23
branch
from
f05e98d to
94c95fe
Compare
In most cases the random wait doesn't help, as users just want to use the admin panel, not test how it reacts to bad network condition. For now I just reduced it, maybe later we can add a toggle Signed-off-by: Lukas Mertens <[email protected]> commit-id:fdcfca23
lukas-mertens
force-pushed
the
spr/main/fdcfca23
branch
from
94c95fe to
3b1912f
Compare
lukas-mertens
force-pushed
the
spr/main/4c4eb3f1
branch
from
0580186 to
699820c
Compare
thexyno
approved these changes
Apr 24, 2024
|
✓ Commit merged in pull request #164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases the random wait doesn't help, as users just want to use
the admin panel, not test how it reacts to bad network condition. For
now I just reduced it, maybe later we can add a toggle
Signed-off-by: Lukas Mertens [email protected]
Stack: