refactor(CreateConfig): use correct type for validateConfigContent #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 12, 2024
lukas-mertens
force-pushed
the
10-12-chore_deps_install_missing_types_js-yaml
branch
from
4962c36 to
01cb49b
Compare
lukas-mertens
force-pushed
the
10-12-refactor_createconfig_use_correct_type_for_validateconfigcontent
branch
from
1b6c545 to
ecbba68
Compare
lukas-mertens
force-pushed
the
10-12-chore_deps_install_missing_types_js-yaml
branch
from
01cb49b to
9ca508e
Compare
lukas-mertens
force-pushed
the
10-12-refactor_createconfig_use_correct_type_for_validateconfigcontent
branch
from
ecbba68 to
8ddb7aa
Compare
lukas-mertens
force-pushed
the
10-12-chore_deps_install_missing_types_js-yaml
branch
from
9ca508e to
bee3b1f
Compare
lukas-mertens
force-pushed
the
10-12-refactor_createconfig_use_correct_type_for_validateconfigcontent
branch
from
8ddb7aa to
f83adc1
Compare
lukas-mertens
force-pushed
the
10-12-chore_deps_install_missing_types_js-yaml
branch
from
bee3b1f to
e47bf93
Compare
lukas-mertens
force-pushed
the
10-12-refactor_createconfig_use_correct_type_for_validateconfigcontent
branch
from
f83adc1 to
1c5ac39
Compare
lukas-mertens
force-pushed
the
10-12-chore_deps_install_missing_types_js-yaml
branch
from
e47bf93 to
debabdf
Compare
lukas-mertens
force-pushed
the
10-12-refactor_createconfig_use_correct_type_for_validateconfigcontent
branch
from
1c5ac39 to
8ce3a52
Compare
This was referenced Oct 12, 2024
lukas-mertens
force-pushed
the
10-12-chore_deps_install_missing_types_js-yaml
branch
from
debabdf to
2516952
Compare
lukas-mertens
force-pushed
the
10-12-refactor_createconfig_use_correct_type_for_validateconfigcontent
branch
from
8ce3a52 to
316f8bf
Compare
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
lukas-mertens
force-pushed
the
10-12-chore_deps_install_missing_types_js-yaml
branch
from
2516952 to
00097c1
Compare
lukas-mertens
force-pushed
the
10-12-refactor_createconfig_use_correct_type_for_validateconfigcontent
branch
from
316f8bf to
b543959
Compare
lukas-mertens
changed the base branch from
10-12-chore_deps_install_missing_types_js-yaml
to
main
The result of yaml.load is of type "unknown", not "object", so we can't assume the input to validateConfigContent is even an object. Noticed while fixing all errors caused by executing vue-tsc Signed-off-by: Lukas Mertens <[email protected]>
lukas-mertens
force-pushed
the
10-12-refactor_createconfig_use_correct_type_for_validateconfigcontent
branch
from
b543959 to
8705f1b
Compare
felix-ulonska
approved these changes
Oct 15, 2024
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of yaml.load is of type "unknown", not "object", so we can't
assume the input to validateConfigContent is even an object.
Noticed while fixing all errors caused by executing vue-tsc
Signed-off-by: Lukas Mertens [email protected]