Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OCPP2.0.1 Plug&Charge #588

Merged
merged 8 commits into from
Mar 21, 2024
Merged

Conversation

Pietfried
Copy link
Contributor

@Pietfried Pietfried commented Mar 19, 2024

Describe your changes

Added support for OCPP2.0.1 Plug&Charge:

  • Changed evse_security.yaml interface: Now two separate functions exist to get ocsp request data to be able to request the ocsp data for MO contract certificates
  • LeafCertificateType enum was extended with the additional value: MO
  • Refactored EvseSecurity and the lib/ocpp to address the required types/interface changes
  • Added conversion function in OCPP201 module
  • Changed EvseV2G module so that it always includes the OCSP request data of the contract certificate and optionally includes the certificate in the ProvidedIdToken
  • Added P&C config for OCPP201

Issue ticket number and link

requires:

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

* Changed evse_security.yaml interface: Now two separate functions exist to get ocsp request data to be able to request the ocsp data for MO contract certificates
* LeafCertificateType enum was extended with the additional value: MO
* Refactored EvseSecurity and the lib/ocpp to address the required types/interface changes
* Added conversion function in OCPP201 module
* Changed EvseV2G module so that it always includes the OCSP request data of the contract certificate and optionally includes the certificate in the ProvidedIdToken
* Added P&C config for OCPP201

Signed-off-by: pietfried <[email protected]>
Copy link
Contributor

@AssemblyJohn AssemblyJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The security part looks good to me.

Copy link
Contributor

@SebaLukas SebaLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The iso part looks good except one small thing (a not needed else)

@SebaLukas
Copy link
Contributor

And clang-format has some problem

Signed-off-by: pietfried <[email protected]>
Signed-off-by: pietfried <[email protected]>
@Pietfried Pietfried merged commit b1c9c4f into main Mar 21, 2024
5 checks passed
@Pietfried Pietfried deleted the feature/ocpp201-pnc-support branch March 21, 2024 13:38
shankari added a commit to US-JOET/everest-demo that referenced this pull request Mar 27, 2024
This ensures that it includes the changes required to support OCPP PnC
EVerest/everest-core#588

This involves:
- Changing the tag to `2024.3.0-rc1`
- Bumping up the version number in the `.env`
- Copying over two nodered configurations:
    - to support MREC in the UI (EVerest/everest-core@9e182a9)
    - to support PnC in the UI (EVerest/everest-core@56a9ff2)
  These are identical to the ones in everest-core at the specified tag, except that they connect to the `mqtt-server` MQTT server instead of `localhost`
shankari added a commit to US-JOET/everest-demo that referenced this pull request Mar 27, 2024
This ensures that it includes the changes required to support OCPP PnC
EVerest/everest-core#588

This involves:
- Changing the tag to `2024.3.0-rc1`
- Bumping up the version number in the `.env`
- Copying over two nodered configurations:
    - to support MREC in the UI (EVerest/everest-core@9e182a9)
    - to support PnC in the UI (EVerest/everest-core@56a9ff2)
  These are identical to the ones in everest-core at the specified tag, except that they connect to the `mqtt-server` MQTT server instead of `localhost`
shankari added a commit to US-JOET/everest-demo that referenced this pull request Mar 27, 2024
This ensures that it includes the changes required to support OCPP PnC
EVerest/everest-core#588

This involves:
- Changing the tag to `2024.3.0-rc1`
- Bumping up the version number in the `.env`
- Copying over two nodered configurations:
    - to support MREC in the UI (EVerest/everest-core@9e182a9)
    - to support PnC in the UI (EVerest/everest-core@56a9ff2)
  These are identical to the ones in everest-core at the specified tag, except that they connect to the `mqtt-server` MQTT server instead of `localhost`

Signed-off-by: Shankari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants