feat: add optional support for TLS trusted_ca_keys extension #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-ctc
requested review from
corneliusclaussen,
SebaLukas,
AssemblyJohn,
Pietfried and
hikinggrass
as code owners
james-ctc
added
Draft
|
non-blocking API added; now ready for review |
james-ctc
force-pushed
the
feat/tls-trusted-ca-keys
branch
from
1b6d7e6 to
f6bbee5
Compare
corneliusclaussen
force-pushed
the
feat/tls-trusted-ca-keys
branch
from
685e830 to
41009f1
Compare
james-ctc
force-pushed
the
feat/tls-trusted-ca-keys
branch
3 times, most recently
from
c9cdd77 to
b4cadc2
Compare
SebaLukas
approved these changes
Aug 9, 2024
|
Please wait for a review from @AssemblyJohn before merging |
james-ctc
force-pushed
the
feat/tls-trusted-ca-keys
branch
3 times, most recently
from
07b7e71 to
c887b89
Compare
AssemblyJohn
approved these changes
Aug 12, 2024
james-ctc
force-pushed
the
feat/tls-trusted-ca-keys
branch
from
26ca3c7 to
c645f67
Compare
@Pietfried review complete, awaiting code owner review/approval. |
feat: add documentation
fix: consistent type naming convention applied
fix: failed tests
feat: added signal to stop stop server
feat: SA_RESTART flag + notes on client certificates
fix: memory leak
feat: testing non-blocking read
feat: patched test only includes the test that would fail
on an unpatched OpenSSL
fix: logging to omit filename and line information
fix: partial config support improved where trust anchors are missing
feat: added non-blocking read/write/connect/accept to TLS implementation
non-blocking is selected by specifying timout_ms == 0
fix: improve string copy safety for private key password
feat: simplified ConfigItem class
ConfigItem is now based on std::optional and std::string
reverted condition variable wait since an occasional failure
was occuring during test runs (not seen previously).
fix: revert back to using EVLOG_ rather than calling boost directly
fix: codacy suggestions addressed
fix: more codacy recommendations and review from AW
fix: error when building MBedTLS version
fix: changed to use auto& ref as per review comment
fix: re-enabled unit tests
fix: attempt to fix getting required files to the right place for unit tests
fix: attempt to fix non-patched OpenSSL unit tests
Signed-off-by: James Chapman <[email protected]>
james-ctc
force-pushed
the
feat/tls-trusted-ca-keys
branch
from
c645f67 to
5fbb02d
Compare
barsnick
reviewed
Aug 14, 2024
Pietfried
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add documentation
fix: consistent type naming convention applied
fix: failed tests
feat: added signal to stop stop server
feat: SA_RESTART flag + notes on client certificates fix: memory leak
feat: testing non-blocking read
feat: patched test only includes the test that would fail
on an unpatched OpenSSL
fix: logging to omit filename and line information fix: partial config support improved where trust anchors are missing
Describe your changes
Added support for TLS trusted_ca_keys extension.
Note its use is disabled since changes to EVSE Security are needed to obtain the trust anchor certificates needed by the extension
Issue ticket number and link
Checklist before requesting a review