Add simple EvAPI and extend EvManager with simplistic SoC calculation #891

hikinggrass · 2024-10-06T08:58:06Z

Describe your changes

Issue ticket number and link

Checklist before requesting a review

I have performed a self-review of my code
I have made corresponding changes to the documentation
I read the contribution documentation and made sure that my changes meet its requirements

Signed-off-by: Kai-Uwe Hermann <[email protected]>

…nnectors" This allows both the API and EvAPI modules to run simultaneously Signed-off-by: Kai-Uwe Hermann <[email protected]>

Signed-off-by: Kai-Uwe Hermann <[email protected]>

This allows an EV implementation to report more detailed information such as SoC Signed-off-by: Kai-Uwe Hermann <[email protected]>

Signed-off-by: Kai-Uwe Hermann <[email protected]>

SebaLukas · 2024-11-07T07:37:38Z

Maybe we can combine the new ev_manager interface with the existing car_simulator interface. I see no problem with moving the cmds and var from the car_simulator interface to the ev_manager interface.

SebaLukas

In general, things are looking good. See my two comments.

modules/EvAPI/EvAPI.hpp

modules/EvAPI/EvAPI.cpp

MarzellT · 2024-11-07T07:42:08Z

modules/EvAPI/EvAPI.hpp

+
+    std::list<std::unique_ptr<EvSessionInfo>> info;
+
+    const std::string api_base = "everest_api/";


Perhaps make this a static inline constexpr std::string_view

modules/EvAPI/EvAPI.cpp

MarzellT · 2024-11-07T07:47:29Z

modules/EvAPI/EvAPI.cpp

+        std::string var_base = ev_base + "/var/";
+
+        std::string var_ev_info = var_base + "ev_info";
+        ev->subscribe_ev_info([this, &ev, var_ev_info](types::evse_manager::EVInfo ev_info) {
+            json ev_info_json = ev_info;
+            this->mqtt.publish(var_ev_info, ev_info_json.dump());
+        });
+
+        std::string var_session_info = var_base + "session_info";
+        ev->subscribe_bsp_event([this, var_session_info, &session_info](const auto& bsp_event) {
+            session_info->update_state(types::board_support_common::event_to_string(bsp_event.event));
+            this->mqtt.publish(var_session_info, *session_info);
+        });


I think it could improve readability if those blocks are refactored to static functions like publish_ev_info and publish_session_info

modules/EvManager/main/car_simulation.cpp

modules/EvManager/main/car_simulation.hpp

Signed-off-by: Kai-Uwe Hermann <[email protected]>

This is was only used for AC, where we now get it via the config Signed-off-by: Kai-Uwe Hermann <[email protected]>

Signed-off-by: Kai-Uwe Hermann <[email protected]>

…e enum Signed-off-by: Kai-Uwe Hermann <[email protected]>

…s cmd the EvManager goes to state ISO_CHARGING_REGULATED and then the new simulate_soc() works also for DC Signed-off-by: Sebastian Lukas <[email protected]>

Signed-off-by: Kai-Uwe Hermann <[email protected]>

hikinggrass · 2024-11-21T13:55:43Z

Maybe we can combine the new ev_manager interface with the existing car_simulator interface. I see no problem with moving the cmds and var from the car_simulator interface to the ev_manager interface.

I can open a follow-up PR for that

hikinggrass · 2024-11-21T14:13:19Z

modules/EvManager/main/car_simulation.cpp

+    if (not state_has_changed and
+        (sim_data.state == SimState::CHARGING_REGULATED or sim_data.state == SimState::CHARGING_FIXED or
+         sim_data.state == SimState::ISO_CHARGING_REGULATED)) {
+        simulate_soc();


Maybe this should already be triggered at startup, right now the ev_info is only published when a charging session is ongoing, but the SoC information is available all the time

Yes, I think you could do this and only sim_data.battery_charge_wh will be increased during charging.

SirVer · 2024-11-21T16:27:37Z

I am not sure why I was added into this code review. @hikinggrass This does not seem to touch Rust or Bazel?

hikinggrass · 2024-11-21T16:38:34Z

I am not sure why I was added into this code review. @hikinggrass This does not seem to touch Rust or Bazel?

Doesn't touch rust or bazel, review request were triggered by accident from a botched merge of main into this branch. I've removed the accidentally added reviewers again

SebaLukas

👍

corneliusclaussen force-pushed the feature/ev-api branch from 7ae8d8d to bc64cb7 Compare October 25, 2024 09:23

Add simple EvAPI and extend EvManager with simplistic SoC calculation

b7a727d

Signed-off-by: Kai-Uwe Hermann <[email protected]>

corneliusclaussen force-pushed the feature/ev-api branch from bc64cb7 to b7a727d Compare October 25, 2024 09:25

hikinggrass added 14 commits November 6, 2024 11:19

Merge branch 'main' into feature/ev-api

5fcc16b

cleanup

feeb598

Signed-off-by: Kai-Uwe Hermann <[email protected]>

Public EvAPI connectors in "ev_connectors" do not use regular API "co…

921a7f7

…nnectors" This allows both the API and EvAPI modules to run simultaneously Signed-off-by: Kai-Uwe Hermann <[email protected]>

Remove session event from ev manager interface since it is not used

ed02b39

Signed-off-by: Kai-Uwe Hermann <[email protected]>

Add EVInfo variable to ev board support interface

3a919b2

This allows an EV implementation to report more detailed information such as SoC Signed-off-by: Kai-Uwe Hermann <[email protected]>

Remove car manufacturer from ev manager interface since it is not used

fad56c4

Signed-off-by: Kai-Uwe Hermann <[email protected]>

Re-publish bsp event in exeisting subscriber

038a90e

Signed-off-by: Kai-Uwe Hermann <[email protected]>

Re-publish ev info coming from ev board support

59bc9b9

Signed-off-by: Kai-Uwe Hermann <[email protected]>

Add description to ev manager provide

5e9a275

Signed-off-by: Kai-Uwe Hermann <[email protected]>

Remove wring years from license header

eb4f634

Signed-off-by: Kai-Uwe Hermann <[email protected]>

Fix naming of charge current/voltage, add AC nominal voltage to config

81a79d8

Signed-off-by: Kai-Uwe Hermann <[email protected]>

Remove EvAPI from config-sil again

d7a67ae

Signed-off-by: Kai-Uwe Hermann <[email protected]>

Use EvSessionInfo in EvAPI with reduced information compared to API

fcf43bf

Signed-off-by: Kai-Uwe Hermann <[email protected]>

clang-format

5060f53

Signed-off-by: Kai-Uwe Hermann <[email protected]>

hikinggrass marked this pull request as ready for review November 6, 2024 19:07

hikinggrass requested review from SebaLukas, Pietfried, MarzellT and corneliusclaussen as code owners November 6, 2024 19:07

SebaLukas reviewed Nov 7, 2024

View reviewed changes

modules/EvAPI/EvAPI.hpp Outdated Show resolved Hide resolved

MarzellT reviewed Nov 7, 2024

View reviewed changes

hikinggrass added 5 commits November 7, 2024 13:02

Refactor EvSessioninfo

ba781f8

Signed-off-by: Kai-Uwe Hermann <[email protected]>

cleanup + const

2ec49b9

Signed-off-by: Kai-Uwe Hermann <[email protected]>

Remove unnecessary charge_voltage_v member variables

8bc6ab4

This is was only used for AC, where we now get it via the config Signed-off-by: Kai-Uwe Hermann <[email protected]>

make ms factor constexpr

536e8fb

Signed-off-by: Kai-Uwe Hermann <[email protected]>

Replace charge_ac and charge_three_phase bool members with charge_mod…

17c9998

…e enum Signed-off-by: Kai-Uwe Hermann <[email protected]>

Adding iso_dc_power_on cmd to all node-red config-sil files. With thi…

c679a32

…s cmd the EvManager goes to state ISO_CHARGING_REGULATED and then the new simulate_soc() works also for DC Signed-off-by: Sebastian Lukas <[email protected]>

hikinggrass requested review from SirVer, dorezyuk, maaikez, james-ctc and a-w50 as code owners November 21, 2024 13:37

Merge remote-tracking branch 'origin/main' into feature/ev-api

a86c62d

Signed-off-by: Kai-Uwe Hermann <[email protected]>

hikinggrass force-pushed the feature/ev-api branch from 3e55818 to a86c62d Compare November 21, 2024 13:43

hikinggrass added 2 commits November 21, 2024 14:47

fix codacy issue

633fc08

Signed-off-by: Kai-Uwe Hermann <[email protected]>

clang-format

a902c7f

Signed-off-by: Kai-Uwe Hermann <[email protected]>

hikinggrass requested a review from SebaLukas November 21, 2024 13:56

hikinggrass commented Nov 21, 2024

View reviewed changes

hikinggrass removed request for SirVer, maaikez, dorezyuk, james-ctc and a-w50 November 21, 2024 16:37

Merge branch 'main' into feature/ev-api

5879dd3

Pietfried requested a review from MarzellT December 3, 2024 09:50

Pietfried assigned SebaLukas and MarzellT Dec 3, 2024

SebaLukas approved these changes Dec 9, 2024

View reviewed changes

Merge branch 'main' into feature/ev-api

a89c6c3

Pietfried assigned corneliusclaussen and unassigned SebaLukas and MarzellT Dec 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add simple EvAPI and extend EvManager with simplistic SoC calculation #891

Add simple EvAPI and extend EvManager with simplistic SoC calculation #891

hikinggrass commented Oct 6, 2024

SebaLukas commented Nov 7, 2024

SebaLukas left a comment

MarzellT Nov 7, 2024

MarzellT Nov 7, 2024

hikinggrass commented Nov 21, 2024

hikinggrass Nov 21, 2024

SebaLukas Dec 9, 2024

SirVer commented Nov 21, 2024

hikinggrass commented Nov 21, 2024

SebaLukas left a comment


		std::list<std::unique_ptr<EvSessionInfo>> info;

		const std::string api_base = "everest_api/";

Add simple EvAPI and extend EvManager with simplistic SoC calculation #891

Are you sure you want to change the base?

Add simple EvAPI and extend EvManager with simplistic SoC calculation #891

Conversation

hikinggrass commented Oct 6, 2024

Describe your changes

Issue ticket number and link

Checklist before requesting a review

SebaLukas commented Nov 7, 2024

SebaLukas left a comment

Choose a reason for hiding this comment

MarzellT Nov 7, 2024

Choose a reason for hiding this comment

MarzellT Nov 7, 2024

Choose a reason for hiding this comment

hikinggrass commented Nov 21, 2024

hikinggrass Nov 21, 2024

Choose a reason for hiding this comment

SebaLukas Dec 9, 2024

Choose a reason for hiding this comment

SirVer commented Nov 21, 2024

hikinggrass commented Nov 21, 2024

SebaLukas left a comment

Choose a reason for hiding this comment