- Fix TC_SECC_CMN_VTB_CmSlacParm_004/5/6 #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusclaussen
added
the
post-release
corneliusclaussen
force-pushed
the
bugfix/slac_tests
branch
from
bdf3672 to
0062b97
Compare
a-w50
reviewed
Oct 24, 2024
a-w50
reviewed
Oct 27, 2024
There was a problem hiding this comment.
Style-wise I'm fine. But it looks like the only necessary change for the 4/5/6 tests is the checking for a valid cm_slac_match_req message.
Everything else seems to be unrelated and I would appreciate if we could add this in a separate commit with corresponding documentation (i.e. what the WaitForLinkState is for and why it can resend the slac_match_cnf message).
corneliusclaussen
force-pushed
the
bugfix/slac_tests
branch
2 times, most recently
from
0979dd3 to
432fd89
Compare
- Fix TC_SECC_CMN_VTB_CmSlacMatch_003 - Add reset event handling while waiting for Link - Add link detection to matching state and reset if link got lost Signed-off-by: Cornelius Claussen <[email protected]> Signed-off-by: aw <[email protected]>
corneliusclaussen
force-pushed
the
bugfix/slac_tests
branch
from
432fd89 to
3e467c6
Compare
corneliusclaussen
removed
the
post-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review