-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module for NXP PN7160 NFC chip as token provider #951
Conversation
dependencies.yaml
Outdated
# linux_libnfc-nci for RFID | ||
libnfc-nci: | ||
git: https://github.com/EVerest/linux_libnfc-nci.git | ||
git_tag: 202411.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor observation, for consistency with the other repos that use a date based version this could be 2024.11.0 (since it's date based it's not a semantic version anyway)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can also have a
cmake_condition: "EVEREST_DEPENDENCY_ENABLED_LIBNFC_NCI"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A find_package somewhere around here needs to be added as well:
Line 111 in 5cc8b6d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I don't know in which situation it would be used: Is a BUILD.libnfc_nci.bazel required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this entry:
everest-core/module-dependencies.cmake
Line 65 in ab1bb79
ev_define_dependency( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure here, but these files are copied from somewhere, and hence we should check and indicate their licensing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are Apache-2.0-licensed. I will add according headers to them.
this->callback = std::move(callback_); | ||
|
||
registerTagCallback(&nfc_callbacks); | ||
doEnableDiscovery(DEFAULT_NFA_TECH_MASK, 0x01, 0x0, 0x1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line would benefit from some more explicit documentation about the flags
10f8250
to
ab1bb79
Compare
530394c
to
c5d8fbf
Compare
Signed-off-by: Christoph Burandt <christoph.burandt@pionix.de>
- add missing find_package in top-level CMakeLists.txt - fix Version no. in dependencies.yaml - fix clang-format violations - add license headers to libnfc-nci config files - add explaining comment to nfc discovery ininitialization - use cmake property to extract config install path from libnfc_nci Signed-off-by: Christoph Burandt <christoph.burandt@pionix.de>
Signed-off-by: Christoph Burandt <christoph.burandt@pionix.de>
c5d8fbf
to
b143c62
Compare
Signed-off-by: Christoph Burandt <christoph.burandt@pionix.de>
02c8cfc
to
6ef9963
Compare
Signed-off-by: cburandt <christoph.burandt@pionix.de>
Signed-off-by: Christoph Burandt <christoph.burandt@pionix.de>
Signed-off-by: Christoph Burandt <christoph.burandt@pionix.de>
Add module for NXP PN7160 NFC chip as token provider.
Adds EVerest/linux_libnfc-nci (forked from NXPNFCLinux and patched to work well with EVerest).