Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MREC9AuthorizationTimeout Error #956

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Conversation

corneliusclaussen
Copy link
Contributor

Describe your changes

Add support for MREC9 authorization timeout error code reporting (car was plugged but never authorized)

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

@Pietfried
Copy link
Contributor

This currently causes some issues with OCPP1.6 since the error raising and SessionEvents do overlap in a way here, potentially causing something like:

image

Is it intended that this error prevents charging (also causing yet another StatusNotification.req in OCPP)?

@corneliusclaussen
Copy link
Contributor Author

Is it intended that this error prevents charging (also causing yet another StatusNotification.req in OCPP)?

This is debatable. In principle yes, as no charging shall be possible without replugging. I'm not sure if the Auth manager already takes care of this, in which case we would not need a second inoperative here. ChargeX is unfortunately absolutely unclear on how they thought this should be used.

@Pietfried
Copy link
Contributor

Is it intended that this error prevents charging (also causing yet another StatusNotification.req in OCPP)?

This is debatable. In principle yes, as no charging shall be possible without replugging. I'm not sure if the Auth manager already takes care of this, in which case we would not need a second inoperative here. ChargeX is unfortunately absolutely unclear on how they thought this should be used.

Ok. The EvseManager already publishes a PluginTimeout session event so the information is already transmitted (StatusNotification(status=Finishing, info=ConnectionTimeout) without the MREC error. I still think its ok to send another informational StatusNotification for it

@corneliusclaussen
Copy link
Contributor Author

@Pietfried I like the config option change with default off. I'm ok with merging now as is.

@Pietfried
Copy link
Contributor

@Pietfried I like the config option change with default off. I'm ok with merging now as is.

Ok, Im fine with merging this as well

corneliusclaussen and others added 2 commits March 4, 2025 11:28
Signed-off-by: Cornelius Claussen <[email protected]>
…le. It controls if an mrec9 error is raised in case of an authorization timeout.

Signed-off-by: Piet Gömpel <[email protected]>
@corneliusclaussen corneliusclaussen merged commit c3575d1 into main Mar 4, 2025
11 of 12 checks passed
@corneliusclaussen corneliusclaussen deleted the feature/MREC9 branch March 4, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants