Skip to content

feat: simplified ConfigItem class

Codacy Production / Codacy Static Code Analysis required action Aug 1, 2024 in 0s

22 new issues (0 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 9
- Added 22
           

Clones added
============
- lib/staging/tls/tests/tls_connection_test.cpp  67
- lib/staging/tls/extensions/trusted_ca_keys.cpp  2
- lib/staging/tls/extensions/status_request.hpp  4
- lib/staging/tls/tests/tls_connection_test.hpp  2
- lib/staging/tls/extensions/status_request.cpp  1
- lib/staging/tls/tests/openssl_util_test.cpp  5
- modules/EvseV2G/tests/openssl_test.cpp  1
- lib/staging/tls/tests/tls_test.cpp  8
- lib/staging/tls/tls.cpp  17
         

Clones removed
==============
+ lib/staging/tls/tests/gtest_main.cpp  -1
+ lib/staging/tls/tests/patched_test.cpp  -25
+ lib/staging/tls/tls.hpp  -4

See the complete overview on Codacy

Annotations

Check notice on line 269 in lib/staging/tls/extensions/status_request.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

lib/staging/tls/extensions/status_request.cpp#L269 

The scope of the variable 'resp_len' can be reduced.

Check notice on line 269 in lib/staging/tls/extensions/status_request.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

lib/staging/tls/extensions/status_request.cpp#L269 

Variable 'resp_len' is assigned a value that is never used.

Check notice on line 60 in lib/staging/tls/openssl_util.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

lib/staging/tls/openssl_util.cpp#L60 

Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120).

Check notice on line 62 in lib/staging/tls/openssl_util.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

lib/staging/tls/openssl_util.cpp#L62 

Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126).

Check warning on line 4 in lib/staging/tls/tests/pki/pki.sh

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

lib/staging/tls/tests/pki/pki.sh#L4 

Double quote to prevent globbing and word splitting.

Check warning on line 13 in lib/staging/tls/tests/pki/pki.sh

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

lib/staging/tls/tests/pki/pki.sh#L13 

Double quote to prevent globbing and word splitting.

Check warning on line 17 in lib/staging/tls/tests/pki/pki.sh

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

lib/staging/tls/tests/pki/pki.sh#L17 

Double quote to prevent globbing and word splitting.

Check warning on line 18 in lib/staging/tls/tests/pki/pki.sh

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

lib/staging/tls/tests/pki/pki.sh#L18 

Double quote to prevent globbing and word splitting.

Check warning on line 21 in lib/staging/tls/tests/pki/pki.sh

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

lib/staging/tls/tests/pki/pki.sh#L21 

Double quote to prevent globbing and word splitting.

Check warning on line 22 in lib/staging/tls/tests/pki/pki.sh

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

lib/staging/tls/tests/pki/pki.sh#L22 

Double quote to prevent globbing and word splitting.

Check warning on line 25 in lib/staging/tls/tests/pki/pki.sh

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

lib/staging/tls/tests/pki/pki.sh#L25 

Double quote to prevent globbing and word splitting.

Check warning on line 26 in lib/staging/tls/tests/pki/pki.sh

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

lib/staging/tls/tests/pki/pki.sh#L26 

Double quote to prevent globbing and word splitting.

Check warning on line 31 in lib/staging/tls/tests/pki/pki.sh

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

lib/staging/tls/tests/pki/pki.sh#L31 

Double quote to prevent globbing and word splitting.

Check warning on line 32 in lib/staging/tls/tests/pki/pki.sh

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

lib/staging/tls/tests/pki/pki.sh#L32 

Double quote to prevent globbing and word splitting.

Check warning on line 35 in lib/staging/tls/tests/pki/pki.sh

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

lib/staging/tls/tests/pki/pki.sh#L35 

Double quote to prevent globbing and word splitting.

Check warning on line 36 in lib/staging/tls/tests/pki/pki.sh

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

lib/staging/tls/tests/pki/pki.sh#L36 

Double quote to prevent globbing and word splitting.

Check warning on line 39 in lib/staging/tls/tests/pki/pki.sh

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

lib/staging/tls/tests/pki/pki.sh#L39 

Double quote to prevent globbing and word splitting.

Check warning on line 40 in lib/staging/tls/tests/pki/pki.sh

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

lib/staging/tls/tests/pki/pki.sh#L40 

Double quote to prevent globbing and word splitting.

Check warning on line 42 in lib/staging/tls/tests/pki/pki.sh

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

lib/staging/tls/tests/pki/pki.sh#L42 

Double quote to prevent globbing and word splitting.

Check warning on line 72 in lib/staging/tls/tests/pki/pki.sh

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

lib/staging/tls/tests/pki/pki.sh#L72 

Double quote to prevent globbing and word splitting.

Check notice on line 526 in lib/staging/tls/tls.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

lib/staging/tls/tls.cpp#L526 

The scope of the variable 'loop' can be reduced.

Check notice on line 49 in lib/staging/tls/tls.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

lib/staging/tls/tls.hpp#L49 

Class 'ConfigItem' has a constructor with 1 argument that is not explicit.
View more details on Codacy Production