-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add citrine support #53
base: main
Are you sure you want to change the base?
Feature/add citrine support #53
Conversation
….0.15 is missing the build/run-scripts folder
Signed-off-by: thanaParis <[email protected]>
echo "Patching the CSMS to enable EVerest organization" | ||
patch -p1 -i ../everest-demo/maeve/maeve-csms-everest-org.patch | ||
|
||
echo "Patching the CSMS to enable local mo root" | ||
patch -p1 -i ../everest-demo/maeve/maeve-csms-local-mo-root.patch | ||
|
||
echo "Patching the CSMS to enable local mo root" | ||
patch -p1 -i ../everest-demo/maeve/maeve-csms-ignore-ocsp.patch | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thanaParis I wonder if there is some cert checking (similar to the patches here) in Citrine that is failing and causing SP3 to fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Citrine starts up fine with SP3 enabled, so the certs pass validity checks. The issue comes up with EVerest tries to connect--EVerest throws a vague asio error, and Citrine just sees the client hang up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have seen asio
errors before while trying to use the EonTI certs #37 (comment) so it is almost certainly that the certs are misconfigured somewhere. did you try wireshark?
Now that #50 is fixed, the current main works with citrine and SP1; there are currently no errors. Please pull and re-apply your changes.
|
@shankari I addressed the comments left and appeased the static code analysis :) Let me know if you would want any further changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should standardize on 80/443 for ws and wss and not have separate ports for citrine and MaEVe. That is how production systems will run anyway, and it will allow us to switch between CSMSes, showcasing the iteroperability provided by standardization. But let's do that as part of the ngrok
changes.
demo-iso15118-2-ac-plus-ocpp.sh
Outdated
echo "Cloning MaEVe CSMS from ${MAEVE_REPO} into ${DEMO_DIR}/maeve-csms and starting it" | ||
git clone "${MAEVE_REPO}" maeve-csms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thanaParis @ChrisWeissmann I am merging this for now, but I would really like to see a copy-pasted "testing done" in future PRs. I don't believe that this script will work, since MAEVE_REPO
is not defined anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was an artifact of the merge to catch up our branch--my apologies. Fixed now.
Signed-off-by: K. Shankari <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I take that back. I can't merge this because the commits have not been signed off. @thanaParis @ChrisWeissmann all changes to the EVerest project need to be signed off. This is very easy, just use git commit -s
. You can also retroactively sign commits.
https://stackoverflow.com/questions/13043357/git-sign-off-previous-commits
@shankari I did my best in regards to the sign off. But since we have merged main into this branch multiple times it became a huge headache to resolve the merge conflicts again. Since the amount of files that were changed weren't that big I ended up creating a new PR off of current main. (#58 ) It also includes the |
Signed-off-by: Christian Weissmann <[email protected]>
Adding CitrineOS support
New command option '-c' uses CitrineOS instead of MaEVe
citrineos/add_charger.sh contains the requests necessary to commission a charger, including setting the auth header password.
New db files added with presets for CitrineOS websocket servers defined in the feature/everest-demo CitrineOS branch.