Skip to content

Commit

Permalink
Apply suggestions from code review - Update everest-ci to v1.3.1
Browse files Browse the repository at this point in the history
Signed-off-by: Andreas Heinrich <[email protected]>
  • Loading branch information
andistorm committed Jul 29, 2024
1 parent d12af63 commit 2a7bd05
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
6 changes: 2 additions & 4 deletions devcontainer/template/.devcontainer/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ volumes:

services:
mqtt-server:
# LTODO: update tag
image: ghcr.io/everest/everest-dev-environment/mosquitto:refactor-docker-images
image: ghcr.io/everest/everest-dev-environment/mosquitto:v1.3.1
ports:
# allow multiple ports for host to avoid conflicts with other dev environments
- 1883-1983:1883
Expand All @@ -29,8 +28,7 @@ services:
MYSQL_PASSWORD: ocpp

steve:
# LTODO: update tag
image: ghcr.io/everest/everest-dev-environment/steve:refactor-docker-images
image: ghcr.io/everest/everest-dev-environment/steve:v1.3.1
ports:
# allow multiple ports for host to avoid conflicts with other dev environments
- 8180-8280:8180
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# syntax=docker/dockerfile:1
# LTODO: Update tag
FROM ghcr.io/everest/everest-ci/dev-env-base:refactor-docker-images
FROM ghcr.io/everest/everest-ci/dev-env-base:v1.3.1

RUN sudo apt update

Check failure on line 4 in devcontainer/template/.devcontainer/general-devcontainer/Dockerfile

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

devcontainer/template/.devcontainer/general-devcontainer/Dockerfile#L4

Do not use sudo as it leads to unpredictable behavior. Use a tool like gosu to enforce root

Expand Down

0 comments on commit 2a7bd05

Please sign in to comment.