Skip to content

Commit

Permalink
Apply review comments
Browse files Browse the repository at this point in the history
Signed-off-by: Andreas Heinrich <[email protected]>
  • Loading branch information
andistorm committed Aug 16, 2024
1 parent c33ab0d commit 3522399
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion devcontainer/setup-devcontainer.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ if [ "$(ls -A $WORKSPACE_DIR)" ]; then
fi
fi

TMP_DIR="$WORKSPACE_DIR/tmp-everest-dev-environment"
TMP_DIR=$(mktemp --directory)
echo "Clone the everest-dev-environment repository to the workspace directory with the version $VERSION, temporarily.."
git clone --quiet --depth 1 --single-branch --branch "$VERSION" https://github.com/EVerest/everest-dev-environment.git "$TMP_DIR"

Expand Down
4 changes: 2 additions & 2 deletions everest_dev_tool/pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
[project]
name = "everest_dev_tool"
version = "0.0.1"
description = "This tool provides helpfull commands to setup/control your dev environment"
license = { text="MIT" }
description = "This tool provides helpful commands to setup/control your dev environment"
license = { text="Apache-2.0" }
dependencies = []

[project.scripts]
Expand Down
4 changes: 2 additions & 2 deletions everest_dev_tool/src/everest_dev_tool/git_handlers.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ def clone_handler(args: argparse.Namespace, log: logging.Logger = default_logger
log.debug("Running clone handler")

if args.https:
repository_url = f"https://github.com/"
repository_url = "https://github.com/"
else:
repository_url = f"[email protected]:"
repository_url = "[email protected]:"
repository_url = repository_url + f"{ args.organization }/{ args.repository_name }.git"

subprocess.run(["git", "clone", "-b", args.branch, repository_url], check=True)

Check warning on line 16 in everest_dev_tool/src/everest_dev_tool/git_handlers.py

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

everest_dev_tool/src/everest_dev_tool/git_handlers.py#L16

subprocess call - check for execution of untrusted input.

0 comments on commit 3522399

Please sign in to comment.