update get_git_repo_info to avoid KeyError exception #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: bump version
Errors obtaining git information were triggering a KeyError exception
and hence failing to generate release.json
Traceback (most recent call last):
File "/home/james/venv/bin/edm", line 8, in <module>
sys.exit(main())
^^^^^^
File "/home/james/venv/lib/python3.12/site-packages/edm_tool/__init__.py", line 17, in main
edm.main(get_parser())
File "/home/james/venv/lib/python3.12/site-packages/edm_tool/edm.py", line 1667, in main
args.action_handler(args)
File "/home/james/venv/lib/python3.12/site-packages/edm_tool/edm.py", line 1301, in release_handler
if everest_core_repo_info["rev"]:
~~~~~~~~~~~~~~~~~~~~~~^^^^^^^
KeyError: 'rev'
Signed-off-by: James Chapman <[email protected]>
hikinggrass
approved these changes
Nov 30, 2024
hikinggrass
reviewed
Nov 30, 2024
| @@ -4,7 +4,8 @@ | |||
| # | |||
| """Everest Dependency Manager.""" | |||
| from edm_tool import edm | |||
| __version__ = "0.6.2" | |||
|
|
|||
| __version__ = "0.7.0" | |||
There was a problem hiding this comment.
TODO @hikinggrass probably can just be 0.6.3
There was a problem hiding this comment.
I used 0.7.0 because there already is a git tag with that value.
It could be confusing to have a 0.6.3 tag newer than 0.7.0
There was a problem hiding this comment.
Ah I see, then it should probably be something like 0.7.1, I think the 0.7.0 one was created before we decided to use prefixed versions in this repo for everything other than edm.
There still seems to be another issue very similar to the one fixed in this PR, I'll add a commit addressing this to this PR once I have a fix
This ensures that the same edm is invoked as in the rest of the code Fixes an issues where it would not be found in certain venv configurations Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: get_git_repo_info result dictionary missing entries on error
fix: bump version
Errors obtaining git information were triggering a KeyError exception and hence failing to generate release.json