ev-cli: Add argument to get template paths #156
Conversation
Signed-off-by: Kai-Uwe Hermann <[email protected]>
ev-dev-tools/src/ev_cli/ev.py
Outdated
| @@ -740,6 +762,11 @@ def main(): | |||
| 'files (default: {everest-dir}/build/generated/generated/modules)') | |||
| mod_genld_parser.set_defaults(action_handler=module_genld) | |||
|
|
|||
| mod_get_templates_parser = mod_actions.add_parser( | |||
| 'get-templates', aliases=['gt'], parents=[common_parser], help='get paths to template files') | |||
| mod_get_templates_parser.add_argument('-s', '--seperator', type=str, default=';', help='Seperator between interface files (default: ;)') | |||
There was a problem hiding this comment.
it should be separator (not seperator :) ). This gives indeed some flexibility, but maybe it is a bit too much. I know the ; is convenient here, because of cmakes list parsing.
But most unix command line tools find, grep ... I know of return multiple values separated by linebreaks \n, and this would be what I would expect here. On the cmake side one could adapt with using
string(REPLACE "\n" ";" OUTPUT ${OUTPUT})
This might look a bit ugly on the cmake side, but still, this semicolon stuff is more of a cmake implementation detail which shouldn't leak into the implementation of other tools. My point of view might seem a bit finical, but it is important to avoid unnecessary coupling.
Side note: I tried to pass a newline \n as the argument to --seperator, it is possible by passing --seperator $'\n' :)
There was a problem hiding this comment.
I've switched the default to \n and use the --separator flag in everst-core to get it in a cmake compatible format.
…e templates Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
…ation Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
hikinggrass
force-pushed
the
feature/get-templates
branch
from
b9df3a3 to
62634bc
Compare
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: aw <[email protected]>
Signed-off-by: aw <[email protected]>
No description provided.