Reafactor/external central system #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AssemblyJohn
commented
Nov 18, 2024
•
AssemblyJohn
commented
- Abstracted the CentralSystem class
- Allow the usage of an externally provided central system based on a fixture
- Updated Readme
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
AssemblyJohn
force-pushed
the
reafactor/external_central_system
branch
from
b4eb891 to
22fc091
Compare
Signed-off-by: AssemblyJohn <[email protected]>
Pietfried
requested changes
Nov 22, 2024
| @@ -136,7 +158,7 @@ async def start(self, ssl_context=None): | |||
|
|
|||
| self.ws_server.close() | |||
| await self.ws_server.wait_closed() | |||
|
|
|||
| pass # End LocalCentralSystem | |||
There was a problem hiding this comment.
Suggested change
| pass # End LocalCentralSystem |
everest-testing/src/everest/testing/ocpp_utils/central_system.py
Outdated
Show resolved
Hide resolved
Signed-off-by: AssemblyJohn <[email protected]>
Pietfried
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.