Fixed an issue with certificate directory support #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+662
to
+672
| if (verify_file.is_using_directory()) { | ||
| auto& hierarchy = verify_file.get_certficate_hierarchy(); | ||
|
|
||
| // Get all roots and search for a valid self-signed | ||
| for (auto& root : hierarchy.get_hierarchy()) { | ||
| if (root.certificate.is_selfsigned() && root.certificate.is_valid()) | ||
| return root.certificate.get_file().value_or(""); | ||
| } | ||
| } |
There was a problem hiding this comment.
Note: In case there are multiple roots, this interface is probably not adequate. We would need to be able to return a list of certificates somehow.
marcemmers
reviewed
Nov 17, 2023
…n status Signed-off-by: ioanbogdan <[email protected]>
AssemblyJohn
force-pushed
the
bugfix/EV-354-libevse-security-get_verify_file-and-is_ca_certificate_installed
branch
from
a8eb74e to
328c1eb
Compare
Pietfried
approved these changes
Jan 13, 2024
AssemblyJohn
deleted the
bugfix/EV-354-libevse-security-get_verify_file-and-is_ca_certificate_installed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed for bundle directory usage: