Fixed some potentially wrong uses of certificate hash #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AssemblyJohn
force-pushed
the
bugfix/wrong_certif_hash_retrieval
branch
4 times, most recently
from
0c89fb2 to
cea0c20
Compare
…ificate names Signed-off-by: AssemblyJohn <[email protected]>
AssemblyJohn
force-pushed
the
bugfix/wrong_certif_hash_retrieval
branch
from
cea0c20 to
7ad7839
Compare
hikinggrass
reviewed
Mar 14, 2024
Pietfried
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
A instance of using the wrong certificate hash have been fixed. The OCSP cache now builds the certificate hierarchy and retrieves the certificate hash later. A crash has been so prevented.
Naming the certificate leafs have been made clearer, from "SECC_LEAF" to "CSMS_LEAF" or "MF_LEAF" based on the LeafCertificateType.
Issue ticket number and link
Checklist before requesting a review