Docs/extend documentation #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pietfried
approved these changes
Mar 19, 2024
hikinggrass
reviewed
Mar 19, 2024
| @@ -58,10 +58,18 @@ class EvseSecurity { | |||
|
|
|||
| public: | |||
| /// @brief Constructor initializes the certificate and key storage using the given \p file_paths for the different | |||
| /// PKIs. For CA certificates CA bundle files must be specified. For the SECC and CSMS leaf certificates, | |||
| /// directories are specified. | |||
| /// PKIs. For CA certificates CA either bundle files or directories containing the certificates can be specified. | |||
There was a problem hiding this comment.
I think this should be "... For CA certificates either CA bundle files ..."
Pietfried
reviewed
Mar 19, 2024
hikinggrass
approved these changes
Mar 19, 2024
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: pietfried <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: Piet Gömpel <[email protected]>
AssemblyJohn
force-pushed
the
docs/extend_documentation
branch
from
f06510a to
52afff1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Documentation update related to internal library functions.
Issue ticket number and link
Checklist before requesting a review